Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1025643002: Respect old space allocation limit in PagedSpace::AllocateRaw. (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Respect old space allocation limit in PagedSpace::AllocateRaw. BUG=v8:3976 LOG=NO Committed: https://crrev.com/fdc1745e335206d78f13623d5a5468e2754ce549 Cr-Commit-Position: refs/heads/master@{#27364}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Patch Set 3 : Move "always allocate scope" up #

Patch Set 4 : Allow nested AlwaysAllocateScopes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/heap/heap.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
ulan
PTAL
5 years, 9 months ago (2015-03-20 11:20:32 UTC) #2
Hannes Payer (out of office)
LGTM, one comment nit https://codereview.chromium.org/1025643002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1025643002/diff/1/src/heap/heap.cc#newcode1871 src/heap/heap.cc:1871: // sweep collection by failing ...
5 years, 9 months ago (2015-03-20 12:29:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025643002/20001
5 years, 9 months ago (2015-03-20 12:35:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/1084)
5 years, 9 months ago (2015-03-20 12:46:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025643002/40001
5 years, 9 months ago (2015-03-20 14:17:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4061)
5 years, 9 months ago (2015-03-20 14:40:12 UTC) #13
ulan
On 2015/03/20 14:40:12, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-23 11:16:19 UTC) #14
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-23 11:47:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025643002/60001
5 years, 9 months ago (2015-03-23 12:03:19 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-23 13:24:14 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 13:24:22 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fdc1745e335206d78f13623d5a5468e2754ce549
Cr-Commit-Position: refs/heads/master@{#27364}

Powered by Google App Engine
This is Rietveld 408576698