Issue 102563005: [Ozone] Rename GetVSyncProvider to CreateVSyncProvider

Issue 102563005: [Ozone] Rename GetVSyncProvider to CreateVSyncProvider (Closed)

Created:
7 years ago by dnicoara

Modified:
6 years, 11 months ago

Reviewers:
rjkroege, piman

CC:
chromium-reviews, rjkroege, joi+watch-content_chromium.org, ozone-reviews_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Ozone] Rename GetVSyncProvider to CreateVSyncProvider Ozone is actually creating the VSyncProvider. The caller will also take ownership of the VSyncProvider. Updating the method definition to better reflect the intent. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243688

Patch Set 1 #

Patch Set 2 : Fix win #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -22 lines)			Patch
M	content/browser/aura/software_output_device_ozone.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/ozone/dri/dri_surface_factory.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/ozone/dri/dri_surface_factory.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/ozone/impl/file_surface_factory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/ozone/impl/file_surface_factory.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/gfx/ozone/surface_factory_ozone.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/gfx/ozone/surface_factory_ozone.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/gl/gl_surface_egl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_surface_egl.cc	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	ui/gl/gl_surface_win.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dnicoara

piman@ suggested updating the name and return value a while back. This change makes the ...

7 years ago (2013-12-23 16:47:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/102563005/1

6 years, 11 months ago (2014-01-08 15:07:58 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243310

6 years, 11 months ago (2014-01-08 15:37:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/102563005/380001

6 years, 11 months ago (2014-01-08 20:18:22 UTC) #6

Message was sent while issue was closed.

Change committed as 243688

Expand Messages | Collapse Messages