Issue 1025623002: Disable inline vector buffers for WTF::Deque for ASAN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1025623002: Disable inline vector buffers for WTF::Deque for ASAN builds. (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
tkent, haraken, inferno

CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail, oilpan-reviews, Oliver Chang

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Disable inline vector buffers for WTF::Deque for ASAN builds. Speculatively extend r191159 to Deque<> vector buffers. R=tkent BUG=469111 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192247

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/wtf/Deque.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

sof

Please take a look. Somewhat speculative, but there is an inconsistency here. (fwiw, I would ...

5 years, 9 months ago (2015-03-20 10:33:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025623002/1

5 years, 9 months ago (2015-03-20 12:06:31 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192247

5 years, 9 months ago (2015-03-20 12:10:21 UTC) #6

Message was sent while issue was closed.

LGTM