Fix SearchBox::LogEvent for out-of-process iframes.

Fix SearchBox::LogEvent for out-of-process iframes.

BUG=469260
TEST=Site Isolation FYI bots go green

Committed: https://crrev.com/004abfb23be163633c0de711df454626ea950e41
Cr-Commit-Position: refs/heads/master@{#321784}

[alexmos, 2015-03-20 21:26:03]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org, fserb@chromium.org

[alexmos, 2015-03-20 21:27:20]

Fernando and Charlie, could you please take a look at this fix for the current
site isolation FYI failures?

[fserb, 2015-03-20 21:34:40]

lgtm

[Charlie Reis, 2015-03-20 21:37:52]

[+site-isolation-reviews]

Thanks!  LGTM with nits.

(Separately, it may make sense to put a comment on
RenderView::GetMainRenderFrame to say that it's not valid when the main frame is
a WebRemoteFrame.  We may even want to enforce that with a DCHECK?)

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
File chrome/renderer/searchbox/searchbox.cc (right):

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox.cc:163: base::TimeDelta delta;
nit: Put below the comment.

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox.cc:165: // case it won't have
navigationStart().  Use a delta of 0 in this case.
s/navigationStart()/performance()/

Also, "Use the default delta of 0..."

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox.cc:166: if
(!render_view()->GetWebView()->mainFrame()->isWebRemoteFrame()) {
Is there a reason to do !isWebRemoteFrame() rather than isWebLocalFrame()?

[alexmos, 2015-03-20 21:50:57]

Thanks!

> (Separately, it may make sense to put a comment on
> RenderView::GetMainRenderFrame to say that it's not valid when the main frame
is
> a WebRemoteFrame.  We may even want to enforce that with a DCHECK?)

Good idea, let's do that in a separate CL.

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
File chrome/renderer/searchbox/searchbox.cc (right):

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox.cc:163: base::TimeDelta delta;
On 2015/03/20 21:37:52, Charlie Reis wrote:
> nit: Put below the comment.

Done.

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox.cc:165: // case it won't have
navigationStart().  Use a delta of 0 in this case.
On 2015/03/20 21:37:52, Charlie Reis wrote:
> s/navigationStart()/performance()/
> 
> Also, "Use the default delta of 0..."

Done.

https://codereview.chromium.org/1025613005/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox.cc:166: if
(!render_view()->GetWebView()->mainFrame()->isWebRemoteFrame()) {
On 2015/03/20 21:37:52, Charlie Reis wrote:
> Is there a reason to do !isWebRemoteFrame() rather than isWebLocalFrame()?

Thanks, fixed.  Just forgot to switch it around.

[Charlie Reis, 2015-03-20 21:53:21]

LGTM

[alexmos, 2015-03-20 22:03:56]

alexmos@chromium.org changed reviewers:
+ jhawkins@chromium.org

[alexmos, 2015-03-20 22:03:56]

jhawkins@: could you please review this CL for chrome/* owner approval?

[James Hawkins, 2015-03-23 15:04:49]

lgtm

[alexmos, 2015-03-23 15:12:05]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2015-03-23 15:12:06]

The patchset sent to the CQ was uploaded after l-g-t-m from fserb@chromium.org
Link to the patchset: https://codereview.chromium.org/1025613005/#ps20001
(title: "Address Charlie's nits")

[commit-bot: I haz the power, 2015-03-23 15:12:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025613005/20001

[commit-bot: I haz the power, 2015-03-23 16:03:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-23 16:04:11]

Patchset 2 (id:??) landed as
https://crrev.com/004abfb23be163633c0de711df454626ea950e41
Cr-Commit-Position: refs/heads/master@{#321784}