Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/extensions/test_extension_prefs.h

Issue 1025613003: Fix for ERROR:url_pattern_set.cc(240)] Invalid url pattern: chrome://print/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/test_extension_prefs.h
diff --git a/chrome/browser/extensions/test_extension_prefs.h b/chrome/browser/extensions/test_extension_prefs.h
index b451b715ab5d4a385e418d7e2a8d00114fbbfaec..5d0bfa95ab26fafafca02307f90a97cdeb658150 100644
--- a/chrome/browser/extensions/test_extension_prefs.h
+++ b/chrome/browser/extensions/test_extension_prefs.h
@@ -61,6 +61,12 @@ class TestExtensionPrefs {
// As above, but the extension is an app.
scoped_refptr<Extension> AddApp(const std::string& name);
+ // Creates a new Extension with the given name in our temp dir with
+ // Manifest::Location, adds it to our ExtensionPrefs, and returns it.
+ scoped_refptr<Extension> AddExtensionWithManifestLocation(
+ const std::string& name,
+ Manifest::Location location);
+
// Similar to AddExtension, but takes a dictionary with manifest values.
scoped_refptr<Extension> AddExtensionWithManifest(
const base::DictionaryValue& manifest,

Powered by Google App Engine
This is Rietveld 408576698