Fix for ERROR:url_pattern_set.cc(240)] Invalid url pattern: chrome://print/*

extensions/browser/extension_prefs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_prefs.h"
 
 #include <iterator>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_notifier.h"
@@ skipping 545 matching lines @@
 bool ExtensionPrefs::ReadPrefAsBooleanAndReturn(
     const std::string& extension_id,
     const std::string& pref_key) const {
   bool out_value = false;
   return ReadPrefAsBoolean(extension_id, pref_key, &out_value) && out_value;
 }
 
 PermissionSet* ExtensionPrefs::ReadPrefAsPermissionSet(
     const std::string& extension_id,
     const std::string& pref_key) {
-  if (!GetExtensionPref(extension_id))
+  const base::DictionaryValue* extensions = GetExtensionPref(extension_id);
+  if (!extensions)
     return NULL;
 
   // Retrieve the API permissions. Please refer SetExtensionPrefPermissionSet()
   // for api_values format.
   APIPermissionSet apis;
   const base::ListValue* api_values = NULL;
   std::string api_pref = JoinPrefs(pref_key, kPrefAPIs);
   if (ReadPrefAsList(extension_id, api_pref, &api_values)) {
     APIPermissionSet::ParseFromJSON(api_values,
                                     APIPermissionSet::kAllowInternalPermissions,
@@ skipping 13 matching lines @@
   }
 
   // Retrieve the explicit host permissions.
   URLPatternSet explicit_hosts;
   ReadPrefAsURLPatternSet(
       extension_id, JoinPrefs(pref_key, kPrefExplicitHosts),
       &explicit_hosts, Extension::kValidHostPermissionSchemes);
 
   // Retrieve the scriptable host permissions.
   URLPatternSet scriptable_hosts;
-  ReadPrefAsURLPatternSet(
-      extension_id, JoinPrefs(pref_key, kPrefScriptableHosts),
-      &scriptable_hosts, UserScript::ValidUserScriptSchemes());
+  int location_value;
+  int valid_schemes = UserScript::ValidUserScriptSchemes();
+  // Adding CHROMEUI scheme in valid schemes mask if extension is component
+  // extension.
+  if (extensions->GetInteger(kPrefLocation, &location_value) &&
+      Manifest::COMPONENT == static_cast<Manifest::Location>(location_value)) {

[Ken Rockot(use gerrit already), 2015/03/24 16:49:09]

nit: Please swap the operand order here. i.e.:

static_cast<Manifest::Location>(location_value) == Manifest::COMPONENT

This is convention in chromium code.

+    valid_schemes |= URLPattern::SCHEME_CHROMEUI;
+  }
+  ReadPrefAsURLPatternSet(extension_id,
+                          JoinPrefs(pref_key, kPrefScriptableHosts),
+                          &scriptable_hosts, valid_schemes);
 
   return new PermissionSet(
       apis, manifest_permissions, explicit_hosts, scriptable_hosts);
 }
 
 // Set the API or Manifest permissions.
 // The format of api_values is:
 // [ "permission_name1",   // permissions do not support detail.
 //   "permission_name2",
 //   {"permission_name3": value },
@@ skipping 1513 matching lines @@
   extension_pref_value_map_->RegisterExtension(
       extension_id, install_time, is_enabled, is_incognito_enabled);
 
   FOR_EACH_OBSERVER(
       ExtensionPrefsObserver,
       observer_list_,
       OnExtensionRegistered(extension_id, install_time, is_enabled));
 }
 
 }  // namespace extensions