Fix for ERROR:url_pattern_set.cc(240)] Invalid url pattern: chrome://print/*

chrome/browser/extensions/extension_prefs_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_prefs_unittest.h"
 
 #include "base/basictypes.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
 #include "base/prefs/mock_pref_change_callback.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/common/chrome_paths.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/test/mock_notification_observer.h"
 #include "extensions/browser/extension_pref_value_map.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/install_flag.h"
 #include "extensions/common/extension.h"
+#include "extensions/common/extension_builder.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "sync/api/string_ordinal.h"
 
 using base::Time;
 using base::TimeDelta;
 using content::BrowserThread;
 
 namespace extensions {
@@ skipping 868 matching lines @@
     // Other preferences should be untouched.
     EXPECT_TRUE(prefs()->AllowFileAccess(extension_a_->id()));
   }
 
  private:
   scoped_refptr<const Extension> extension_a_;
   scoped_refptr<const Extension> extension_b_;
 };
 TEST_F(ExtensionPrefsClearLastLaunched, ExtensionPrefsClearLastLaunched) {}
 
+class ExtensionPrefsComponentExtension : public ExtensionPrefsTest {
+ public:
+  ~ExtensionPrefsComponentExtension() override {}
+  void Initialize() override {
+    // Adding a component extension.
+    component_extension_ =
+        ExtensionBuilder()
+            .SetManifest(DictionaryBuilder()
+                             .Set(manifest_keys::kName, "test")
+                             .Set(manifest_keys::kVersion, "0.1"))
+            .SetLocation(Manifest::COMPONENT)
+            .Build();
+    prefs_.AddExtension(component_extension_.get());
+
+    // Adding a non component extension.

[not at google - send to devlin, 2015/04/13 17:24:35]

It would be more consistent to set this up in the same way that
|component_extension_| is set up.

[Deepak, 2015/04/14 05:05:42]

Done.

+    no_component_extension_ = prefs_.AddExtension("a");
+
+    APIPermissionSet api_perms;
+    api_perms.insert(APIPermission::kTab);
+    api_perms.insert(APIPermission::kBookmark);
+    api_perms.insert(APIPermission::kHistory);
+
+    ManifestPermissionSet empty_manifest_permissions;
+
+    URLPatternSet ehosts, shosts;
+    AddPattern(&shosts, "chrome://print/*");
+
+    active_perms_ = new PermissionSet(api_perms, empty_manifest_permissions,
+                                      ehosts, shosts);
+    // Set the active permissions.
+    prefs()->SetActivePermissions(component_extension_->id(),
+                                  active_perms_.get());
+    prefs()->SetActivePermissions(no_component_extension_->id(),
+                                  active_perms_.get());
+  }
+
+  void Verify() override {
+    // Component extension can access chrome://print/*.
+    scoped_refptr<PermissionSet> component_permissions(
+        prefs()->GetActivePermissions(component_extension_->id()));
+    EXPECT_FALSE(component_permissions->scriptable_hosts().is_empty());

[not at google - send to devlin, 2015/04/13 17:24:35]

You should be able to EXPECT_EQ(1u, ....size());

[Deepak, 2015/04/14 05:05:42]

Done.

+
+    // Non Component extension can not access chrome://print/*.
+    scoped_refptr<PermissionSet> no_component_permissions(
+        prefs()->GetActivePermissions(no_component_extension_->id()));
+    EXPECT_TRUE(no_component_permissions->scriptable_hosts().is_empty());
+
+    // |URLPattern::SCHEME_CHROMEUI| scheme will be added in valid_schemes for
+    // component extensions.
+    URLPatternSet scriptable_hosts;
+    std::string pref_key = "active_permissions.scriptable_host";
+    EXPECT_TRUE(prefs()->ReadPrefAsURLPatternSet(
+        component_extension_->id(), pref_key, &scriptable_hosts, 15));

[not at google - send to devlin, 2015/04/13 17:24:35]

What is 15? Can you alias it to something meaningful?

[Deepak, 2015/04/14 05:05:42]

Done.

+
+    EXPECT_FALSE(prefs()->ReadPrefAsURLPatternSet(
+        no_component_extension_->id(), pref_key, &scriptable_hosts, 15));
+  }
+
+ private:
+  scoped_refptr<PermissionSet> active_perms_;
+  scoped_refptr<Extension> component_extension_;
+  scoped_refptr<Extension> no_component_extension_;
+};
+TEST_F(ExtensionPrefsComponentExtension, ExtensionPrefsComponentExtension) {
+}
+
 }  // namespace extensions