Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1025613002: Fix ESC not closing the print preview dialog on Mac (Closed)

Created:
5 years, 9 months ago by tapted
Modified:
5 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ESC not closing the print preview dialog on Mac Making toolkit-views available for non-browser UI means that this guard in print_preview.js needs updating to ensure ESC still closes the dialog on Mac. The webui container is still Cocoa. Everything is toolkit-views now (except mobile/cast), so just check for mac. BUG=469045 Committed: https://crrev.com/c29919ce9a98620c21e6e7750a3bb7ed2afebbbe Cr-Commit-Position: refs/heads/master@{#321607}

Patch Set 1 #

Patch Set 2 : Clearer logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/resources/print_preview/print_preview.js View 1 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Aleksey, please take a look
5 years, 9 months ago (2015-03-20 10:18:10 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 9 months ago (2015-03-20 17:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025613002/20001
5 years, 9 months ago (2015-03-20 18:42:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 18:48:57 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 18:49:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c29919ce9a98620c21e6e7750a3bb7ed2afebbbe
Cr-Commit-Position: refs/heads/master@{#321607}

Powered by Google App Engine
This is Rietveld 408576698