Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: src/heap/heap.cc

Issue 1025603003: Don't DCHECK that the weak closure wasn't yet overapproximated (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 1b0ab092f04da91374cb07f7d8b46da18aa75e49..054ebced2a899ff2d20941a4d4b76638de122f8a 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -736,8 +736,9 @@ void Heap::HandleGCRequest() {
return;
}
DCHECK(FLAG_overapproximate_weak_closure);
- DCHECK(!incremental_marking()->weak_closure_was_overapproximated());
- OverApproximateWeakClosure("GC interrupt");
+ if (!incremental_marking()->weak_closure_was_overapproximated()) {
+ OverApproximateWeakClosure("GC interrupt");
+ }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698