Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1025603002: Revert of [S.P.] Don't draw frames of animated images that are offscreen. (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [S.P.] Don't draw frames of animated images that are offscreen. (patchset #10 id:180001 of https://codereview.chromium.org/1008043002/) Reason for revert: Several animation tests started failing intermittently after this change Dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=paint%2Finvalidation%2Fanimated-gif.html%2Cpaint%2Finvalidation%2Fanimated-gif-offscreen.htm Original issue's description: > [S.P.] Don't draw frames of animated images that are offscreen. > > To achieve this, introduces the notion of a delayed paint invalidation. > When invalidating paint for an object, the object now has the option to delay > the invalidation until the next frame. > > BUG=440466 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192219 TBR=enne@chromium.org,wangxianzhu@chromium.org,esprehn@chromium.org,chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440466 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -151 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/paint/invalidation/animated-gif.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/paint/invalidation/animated-gif-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/paint/invalidation/animated-gif-offscreen.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/paint/invalidation/animated-gif-offscreen-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/slimmingpaint/paint/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/slimmingpaint/paint/invalidation/animated-gif-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/virtual/slimmingpaint/paint/invalidation/animated-gif-offscreen-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/layout/LayoutImage.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutImage.cpp View 2 chunks +0 lines, -25 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M Source/platform/graphics/PaintInvalidationReason.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/platform/graphics/PaintInvalidationReason.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
Created Revert of [S.P.] Don't draw frames of animated images that are offscreen.
5 years, 9 months ago (2015-03-20 08:54:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025603002/1
5 years, 9 months ago (2015-03-20 08:54:22 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 08:55:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192233

Powered by Google App Engine
This is Rietveld 408576698