Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1025593002: Add ImageOrientation class. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ImageOrientation class. Currently we uses different number expressing image orientation for EXIF and drive metadata. The CL added generic ImageOrientation class that is going to replace the image orientation numbers. BUG=396702 TEST=ImageOrientationTest Committed: https://crrev.com/cfc48a489802d33d25a3246c6b1f024df8c7e676 Cr-Commit-Position: refs/heads/master@{#321541}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js View 1 2 1 chunk +126 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/image_orientation_unittest.html View 1 chunk +9 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/image_orientation_unittest.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025593002/20001
5 years, 9 months ago (2015-03-20 06:47:43 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-20 06:47:45 UTC) #4
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-20 06:48:02 UTC) #6
yawano
https://codereview.chromium.org/1025593002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js File ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js (right): https://codereview.chromium.org/1025593002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js#newcode62 ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js:62: return new ImageOrientation(0, 1, 1, 0); This matrix is ...
5 years, 9 months ago (2015-03-20 07:35:42 UTC) #7
hirono
Thanks! https://codereview.chromium.org/1025593002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js File ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js (right): https://codereview.chromium.org/1025593002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js#newcode62 ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js:62: return new ImageOrientation(0, 1, 1, 0); On 2015/03/20 ...
5 years, 9 months ago (2015-03-20 08:09:20 UTC) #8
yawano
lgtm. Thank you!
5 years, 9 months ago (2015-03-20 08:43:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025593002/40001
5 years, 9 months ago (2015-03-20 09:39:21 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 10:12:57 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 10:14:00 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cfc48a489802d33d25a3246c6b1f024df8c7e676
Cr-Commit-Position: refs/heads/master@{#321541}

Powered by Google App Engine
This is Rietveld 408576698