Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: sdk/lib/collection/maps.dart

Issue 1025573005: Move implementation from IterableBase to Iterable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove extra "static" on helper functions. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/collection/linked_list.dart ('k') | sdk/lib/collection/queue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/collection/maps.dart
diff --git a/sdk/lib/collection/maps.dart b/sdk/lib/collection/maps.dart
index c0a411d4c89c1db0a6ec4ab10ff3765d436aac6c..7945e7ea643411074c5e65769a5870c0733913c7 100644
--- a/sdk/lib/collection/maps.dart
+++ b/sdk/lib/collection/maps.dart
@@ -111,7 +111,7 @@ abstract class UnmodifiableMapBase<K, V> =
* It accesses the values by iterating over the keys of the map, and using the
* map's `operator[]` to lookup the keys.
*/
-class _MapBaseValueIterable<V> extends IterableBase<V>
+class _MapBaseValueIterable<V> extends Iterable<V>
implements EfficientLength {
final Map _map;
_MapBaseValueIterable(this._map);
@@ -285,11 +285,11 @@ class Maps {
*/
static String mapToString(Map m) {
// Reuse the list in IterableBase for detecting toString cycles.
- if (IterableBase._isToStringVisiting(m)) { return '{...}'; }
+ if (_isToStringVisiting(m)) { return '{...}'; }
var result = new StringBuffer();
try {
- IterableBase._toStringVisiting.add(m);
+ _toStringVisiting.add(m);
result.write('{');
bool first = true;
m.forEach((k, v) {
@@ -303,8 +303,8 @@ class Maps {
});
result.write('}');
} finally {
- assert(identical(IterableBase._toStringVisiting.last, m));
- IterableBase._toStringVisiting.removeLast();
+ assert(identical(_toStringVisiting.last, m));
+ _toStringVisiting.removeLast();
}
return result.toString();
« no previous file with comments | « sdk/lib/collection/linked_list.dart ('k') | sdk/lib/collection/queue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698