QUIC - disable QUIC if packet loss rate is bad for a connection.

net/quic/quic_connection_logger.cc

Index: net/quic/quic_connection_logger.cc
diff --git a/net/quic/quic_connection_logger.cc b/net/quic/quic_connection_logger.cc
index 2005b88165a6fe14d01db79edf278204689afa4b..91bfd029ae682da877cb67b6e6ae344ed9d0244e 100644
--- a/net/quic/quic_connection_logger.cc
+++ b/net/quic/quic_connection_logger.cc
@@ -769,6 +769,13 @@ void QuicConnectionLogger::AddTo21CumulativeHistogram(
   }
 }
 
+float QuicConnectionLogger::ReceivedPacketLossRate() const {
+  if (largest_received_packet_sequence_number_ <= num_packets_received_)
+    return 0.0f;
+  return largest_received_packet_sequence_number_ /
+         (largest_received_packet_sequence_number_ - num_packets_received_);

[Ryan Hamilton, 2015/03/24 03:43:00]

Is this inverted? I would expect the denominator to be larger than the
numerator, otherwise the loss would be greater than 1.

[ramant (doing other things), 2015/03/24 17:19:23]

facepalm. Goofed up. thanks much.

+}
+
 void QuicConnectionLogger::RecordAggregatePacketLossRate() const {
   // For short connections under 22 packets in length, we'll rely on the
   // Net.QuicSession.21CumulativePacketsReceived_* histogram to indicate packet
@@ -779,17 +786,12 @@ void QuicConnectionLogger::RecordAggregatePacketLossRate() const {
   if (largest_received_packet_sequence_number_ <= 21)
     return;
 
-  QuicPacketSequenceNumber divisor = largest_received_packet_sequence_number_;
-  QuicPacketSequenceNumber numerator = divisor - num_packets_received_;
-  if (divisor < 100000)
-    numerator *= 1000;
-  else
-    divisor /= 1000;
   string prefix("Net.QuicSession.PacketLossRate_");
   base::HistogramBase* histogram = base::Histogram::FactoryGet(
       prefix + connection_description_, 1, 1000, 75,
       base::HistogramBase::kUmaTargetedHistogramFlag);
-  histogram->Add(static_cast<base::HistogramBase::Sample>(numerator / divisor));
+  histogram->Add(static_cast<base::HistogramBase::Sample>(
+      ReceivedPacketLossRate() * 1000));
 }
 
 void QuicConnectionLogger::RecordLossHistograms() const {