[Telemtry] Create a temp file for storing wpr's stdout & stderr.

[Telemtry] Create a temp file for storing wpr's stdout & stderr.

Previously, webpagereplay stores all the stdout & stder of the wpr subprocess to
a fix log file path location. It then parses the log lines to get replay server
port  assignment. When there are multiple telemetry processes running in parallel,
this cause a concurrency problem.

This patch addresses the issue by create a temp location for the log file path.
This is to make sure that different telemetry processes will write & read to different
log files.

BUG=469296
Committed: https://crrev.com/8cf5c3d2dd0406a80e8f2f3130212ee7b78839be
Cr-Commit-Position: refs/heads/master@{#322247}

[nednguyen, 2015-03-24 18:11:37]

nednguyen@google.com changed reviewers:
+ slamm@chromium.org, zhenw@chromium.org

[Zhen Wang, 2015-03-24 18:29:31]

On 2015/03/24 18:11:38, nednguyen wrote:

lgtm

[slamm, 2015-03-24 21:01:47]

lgtm

One thing this does is make the WPR logs unavailable after a run.
At least add a TODO to print them to Chrome's log output.

https://codereview.chromium.org/1025553008/diff/1/tools/telemetry/telemetry/c...
File tools/telemetry/telemetry/core/webpagereplay.py (right):

https://codereview.chromium.org/1025553008/diff/1/tools/telemetry/telemetry/c...
tools/telemetry/telemetry/core/webpagereplay.py:80: self._tmp_log_file_path =
None
tmp -> temp to match tempfile and _CreateTempLogFilePath.

[nednguyen, 2015-03-25 08:32:23]

https://codereview.chromium.org/1025553008/diff/1/tools/telemetry/telemetry/c...
File tools/telemetry/telemetry/core/webpagereplay.py (right):

https://codereview.chromium.org/1025553008/diff/1/tools/telemetry/telemetry/c...
tools/telemetry/telemetry/core/webpagereplay.py:80: self._tmp_log_file_path =
None
On 2015/03/24 21:01:47, slamm wrote:
> tmp -> temp to match tempfile and _CreateTempLogFilePath.

Done.

[nednguyen, 2015-03-25 08:32:28]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-03-25 08:32:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025553008/1

[nednguyen, 2015-03-25 08:33:02]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2015-03-25 08:35:43]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-25 08:35:43]

The patchset sent to the CQ was uploaded after l-g-t-m from zhenw@chromium.org,
slamm@chromium.org
Link to the patchset: https://codereview.chromium.org/1025553008/#ps20001
(title: "Address slamm's comment")

[commit-bot: I haz the power, 2015-03-25 08:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025553008/20001

[commit-bot: I haz the power, 2015-03-25 19:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 19:27:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[slamm, 2015-03-25 19:34:39]

https://codereview.chromium.org/1025553008/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/webpagereplay.py (right):

https://codereview.chromium.org/1025553008/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/webpagereplay.py:217:
self._CleanUpTempLogFilePath()
The try job failed because the WPR process is still using the log file.
This needs to move to the end of this function.

[nednguyen, 2015-03-25 20:11:52]

https://codereview.chromium.org/1025553008/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/webpagereplay.py (right):

https://codereview.chromium.org/1025553008/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/webpagereplay.py:217:
self._CleanUpTempLogFilePath()
On 2015/03/25 19:34:39, slamm wrote:
> The try job failed because the WPR process is still using the log file.
> This needs to move to the end of this function.

Thanks Steve.

[nednguyen, 2015-03-25 20:11:55]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-25 20:11:56]

The patchset sent to the CQ was uploaded after l-g-t-m from zhenw@chromium.org,
slamm@chromium.org
Link to the patchset: https://codereview.chromium.org/1025553008/#ps40001
(title: "Move log file clean up to the end of StopServer")

[commit-bot: I haz the power, 2015-03-25 20:13:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025553008/40001

[nednguyen, 2015-03-25 20:17:12]

Patchset #3 (id:40001) has been deleted

[nednguyen, 2015-03-25 20:17:15]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2015-03-25 20:20:54]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-25 20:20:55]

The patchset sent to the CQ was uploaded after l-g-t-m from zhenw@chromium.org,
slamm@chromium.org
Link to the patchset: https://codereview.chromium.org/1025553008/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-25 20:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025553008/60001

[commit-bot: I haz the power, 2015-03-25 22:21:23]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-25 22:21:54]

Patchset 3 (id:??) landed as
https://crrev.com/8cf5c3d2dd0406a80e8f2f3130212ee7b78839be
Cr-Commit-Position: refs/heads/master@{#322247}