Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1025553004: Switch HidDeviceId from IORegistry path to IORegistry entry ID. (Closed)

Created:
5 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch HidDeviceId from IORegistry path to IORegistry entry ID. As of OS X Yosemite the IORegistry paths for Bluetooth HID devices are no longer unique. This change switches to using the entry IDs instead, which appear to remain unique. BUG=452172 Committed: https://crrev.com/fab70f55e19d3090af7d6d51425abed3c8b3e039 Cr-Commit-Position: refs/heads/master@{#321892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -27 lines) Patch
M device/hid/hid_device_filter_unittest.cc View 1 chunk +12 lines, -1 line 0 comments Download
M device/hid/hid_device_info.h View 1 chunk +5 lines, -0 lines 0 comments Download
M device/hid/hid_device_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M device/hid/hid_service_mac.cc View 3 chunks +15 lines, -17 lines 0 comments Download
M extensions/browser/api/hid/hid_apitest.cc View 5 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please look at this one too.
5 years, 9 months ago (2015-03-23 22:15:17 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-23 22:38:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025553004/1
5 years, 9 months ago (2015-03-23 22:42:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 23:21:25 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 23:22:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fab70f55e19d3090af7d6d51425abed3c8b3e039
Cr-Commit-Position: refs/heads/master@{#321892}

Powered by Google App Engine
This is Rietveld 408576698