Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: Source/web/WebViewImpl.h

Issue 1025543002: Remove old pinch-zoom paths from Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebSettingsImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index fee62f9a007786e2fe64a1ce1666036f7202555f..ac1153c3e08c317c8c8654f00e610dba7ad6b18b 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -120,12 +120,6 @@ public:
virtual void setCursorVisibilityState(bool isVisible) override;
virtual bool hasTouchEventHandlersAt(const WebPoint&) override;
- // FIXME(bokan): Old pinch path only - This should be removed once old pinch
- // is removed.
- virtual void applyViewportDeltas(
- const WebSize& scrollDelta,
- float pageScaleDelta,
- float topControlsShownRatioDelta) override;
virtual void applyViewportDeltas(
const WebFloatSize& pinchViewportDelta,
const WebFloatSize& mainFrameDelta,
@@ -516,17 +510,11 @@ public:
// Returns the bounding box of the block type node touched by the WebPoint.
WebRect computeBlockBound(const WebPoint&, bool ignoreClipping);
- // FIXME(bokan): Replace with PinchViewport::clampDocumentOffsetAtScale once
- // old-path is gone.
- IntPoint clampOffsetAtScale(const IntPoint& offset, float scale);
-
// Exposed for tests.
WebVector<WebCompositionUnderline> compositionUnderlines() const;
WebLayerTreeView* layerTreeView() const { return m_layerTreeView; }
- bool pinchVirtualViewportEnabled() const;
-
bool matchesHeuristicsForGpuRasterizationForTesting() const { return m_matchesHeuristicsForGpuRasterization; }
virtual void setTopControlsHeight(float height, bool topControlsShrinkLayoutSize) override;
@@ -544,15 +532,10 @@ public:
PageScaleConstraintsSet& pageScaleConstraintsSet() { return m_pageScaleConstraintsSet; }
private:
- // TODO(bokan): Remains for legacy pinch. Remove once it's gone. Made private to
- // prevent external usage
- virtual void setPageScaleFactor(float scaleFactor, const WebPoint& origin) override;
void setPageScaleFactorAndLocation(float, const FloatPoint&);
void scrollAndRescaleViewports(float scaleFactor, const IntPoint& mainFrameOrigin, const FloatPoint& pinchViewportOrigin);
- IntRect visibleRectInDocument() const;
-
float maximumLegiblePageScale() const;
void refreshPageScaleFactorAfterLayout();
void resumeTreeViewCommits();
« no previous file with comments | « Source/web/WebSettingsImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698