Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 1025543002: Remove old pinch-zoom paths from Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index b31c49bc146ae82dcb767448e4801797d67a26c7..9af8e2ad8b5545ed213d233cae22526a30c97554 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -189,11 +189,7 @@ void FrameLoader::saveScrollState()
return;
m_currentItem->setScrollPoint(m_frame->view()->scrollPosition());
-
- if (m_frame->settings()->pinchVirtualViewportEnabled())
- m_currentItem->setPinchViewportScrollPoint(m_frame->host()->pinchViewport().visibleRect().location());
- else
- m_currentItem->setPinchViewportScrollPoint(FloatPoint(-1, -1));
+ m_currentItem->setPinchViewportScrollPoint(m_frame->host()->pinchViewport().visibleRect().location());
if (m_frame->isMainFrame())
m_currentItem->setPageScaleFactor(m_frame->page()->pageScaleFactor());
@@ -1013,8 +1009,7 @@ void FrameLoader::restoreScrollPositionAndViewState()
// page height increases, 3. ignore clamp detection after load completes
// because that may be because the page will never reach its previous
// height.
- float mainFrameScale = m_frame->settings()->pinchVirtualViewportEnabled() ? 1 : m_currentItem->pageScaleFactor();
- bool canRestoreWithoutClamping = view->clampOffsetAtScale(m_currentItem->scrollPoint(), mainFrameScale) == m_currentItem->scrollPoint();
+ bool canRestoreWithoutClamping = view->clampOffsetAtScale(m_currentItem->scrollPoint(), 1) == m_currentItem->scrollPoint();
bool canRestoreWithoutAnnoyingUser = !view->wasScrolledByUser() && (canRestoreWithoutClamping || m_frame->document()->loadEventFinished());
if (!canRestoreWithoutAnnoyingUser)
return;
@@ -1025,17 +1020,13 @@ void FrameLoader::restoreScrollPositionAndViewState()
m_frame->page()->setPageScaleFactor(m_currentItem->pageScaleFactor(), frameScrollOffset);
- if (m_frame->settings()->pinchVirtualViewportEnabled()) {
- // If the pinch viewport's offset is (-1, -1) it means the history item
- // is an old version of HistoryItem so distribute the scroll between
- // the main frame and the pinch viewport as best as we can.
- // FIXME(bokan): This legacy distribution can be removed once the virtual viewport
- // pinch path is enabled on all platforms for at least one release.
- if (pinchViewportOffset.x() == -1 && pinchViewportOffset.y() == -1)
- pinchViewportOffset = FloatPoint(frameScrollOffset - view->scrollPosition());
+ // If the pinch viewport's offset is (-1, -1) it means the history item
+ // is an old version of HistoryItem so distribute the scroll between
+ // the main frame and the pinch viewport as best as we can.
+ if (pinchViewportOffset.x() == -1 && pinchViewportOffset.y() == -1)
+ pinchViewportOffset = FloatPoint(frameScrollOffset - view->scrollPosition());
- m_frame->host()->pinchViewport().setLocation(pinchViewportOffset);
- }
+ m_frame->host()->pinchViewport().setLocation(pinchViewportOffset);
} else {
view->setScrollPositionNonProgrammatically(m_currentItem->scrollPoint());
}
« no previous file with comments | « Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698