PCHECK when closing UDP sockets only when errno=EBADF.

net/udp/udp_socket_libevent.cc

Index: net/udp/udp_socket_libevent.cc
diff --git a/net/udp/udp_socket_libevent.cc b/net/udp/udp_socket_libevent.cc
index 6fdb94e5eb15e69de304145860163de27489388e..eb605f0c2849adfd5edea621ee99aa999696d249 100644
--- a/net/udp/udp_socket_libevent.cc
+++ b/net/udp/udp_socket_libevent.cc
@@ -126,7 +126,11 @@ void UDPSocketLibevent::Close() {
   ok = write_socket_watcher_.StopWatchingFileDescriptor();
   DCHECK(ok);
 
-  PCHECK(0 == IGNORE_EINTR(close(socket_)));
+  if (IGNORE_EINTR(close(socket_)) == -1) {
+    int last_error = errno;

[rvargas (doing something else), 2015/03/19 23:06:33]

You may be interested in base::debug::Alias

[rvargas (doing something else), 2015/03/19 23:07:18]

nah, that's win only.

[Sergey Ulanov, 2015/03/19 23:52:03]

I think it may be useful on Mac too. Comments don't say anything about it being
windows-specific.

+    // Crash on any error other than EIO.
+    PCHECK(last_error == EIO);
+  }
 
   socket_ = kInvalidSocket;
   addr_family_ = 0;