Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1025503002: Use same base class for popup and plugin blocking UI (Closed)

Created:
5 years, 9 months ago by meacer
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tfarina, markusheintz_, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unneeded override #

Patch Set 3 : Fix test build #

Patch Set 4 : Fix cocoa code #

Total comments: 30

Patch Set 5 : msw comments #

Total comments: 20

Patch Set 6 : groby comments #

Patch Set 7 : Revert renaming #

Patch Set 8 : bauerb comments #

Total comments: 2

Patch Set 9 : Fix row counting #

Total comments: 2

Patch Set 10 : Use actual types in for loops instead of auto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -225 lines) Patch
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 2 3 4 5 6 7 8 9 8 chunks +53 lines, -49 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 1 2 3 4 5 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 3 4 5 6 7 8 9 19 chunks +96 lines, -98 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 2 3 4 5 6 7 8 9 5 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 2 3 4 5 6 7 8 9 3 chunks +32 lines, -46 lines 0 comments Download

Messages

Total messages: 25 (4 generated)
meacer
bauerb, msw: Can you PTAL? Thanks.
5 years, 9 months ago (2015-03-20 19:38:47 UTC) #2
meacer
https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode393 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:393: } This is essentially a revert of https://codereview.chromium.org/777103002/diff/180001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
5 years, 9 months ago (2015-03-20 19:40:04 UTC) #3
msw
https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/content_settings/tab_specific_content_settings.h File chrome/browser/content_settings/tab_specific_content_settings.h (right): https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/content_settings/tab_specific_content_settings.h#newcode183 chrome/browser/content_settings/tab_specific_content_settings.h:183: std::vector<base::string16> GetBlockedPluginNames() const { nit: rename this blocked_plugin_names() https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ...
5 years, 9 months ago (2015-03-20 22:06:34 UTC) #4
meacer
groby@: Can you PTAL at content_setting_bubble_cocoa.mm? wfh@: FYI https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/content_settings/tab_specific_content_settings.h File chrome/browser/content_settings/tab_specific_content_settings.h (right): https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/content_settings/tab_specific_content_settings.h#newcode183 chrome/browser/content_settings/tab_specific_content_settings.h:183: std::vector<base::string16> ...
5 years, 9 months ago (2015-03-20 23:39:43 UTC) #6
groby-ooo-7-16
c/b/ui/cocoa LGTM w/ a few tiny nits https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode389 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:389: [blockedResourcesField_ removeFromSuperview]; ...
5 years, 9 months ago (2015-03-21 00:19:28 UTC) #7
msw
This code could definitely be simplified further, but that isn't necessary for this CL. https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ...
5 years, 9 months ago (2015-03-21 00:25:19 UTC) #8
msw
https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode420 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:420: for (std::vector<ContentSettingBubbleModel::ListItem>::const_iterator On 2015/03/21 00:19:28, groby wrote: > If ...
5 years, 9 months ago (2015-03-21 00:26:30 UTC) #9
meacer
https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode389 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:389: [blockedResourcesField_ removeFromSuperview]; On 2015/03/21 00:19:28, groby wrote: > Why ...
5 years, 9 months ago (2015-03-23 18:19:40 UTC) #10
msw
lgtm with a nit and some plan for consistent naming. https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/content_settings/content_setting_bubble_model.cc File chrome/browser/ui/content_settings/content_setting_bubble_model.cc (right): https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/content_settings/content_setting_bubble_model.cc#newcode486 ...
5 years, 9 months ago (2015-03-23 19:21:06 UTC) #11
meacer
https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/content_settings/content_setting_bubble_model.cc File chrome/browser/ui/content_settings/content_setting_bubble_model.cc (right): https://codereview.chromium.org/1025503002/diff/60001/chrome/browser/ui/content_settings/content_setting_bubble_model.cc#newcode486 chrome/browser/ui/content_settings/content_setting_bubble_model.cc:486: class ContentSettingPluginBubbleModel : public ContentSettingItemListModel { On 2015/03/23 19:21:06, ...
5 years, 9 months ago (2015-03-23 20:23:29 UTC) #12
msw
lgtm
5 years, 9 months ago (2015-03-23 20:27:50 UTC) #13
Bernhard Bauer
https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/content_settings/tab_specific_content_settings.h File chrome/browser/content_settings/tab_specific_content_settings.h (right): https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/content_settings/tab_specific_content_settings.h#newcode183 chrome/browser/content_settings/tab_specific_content_settings.h:183: std::vector<base::string16> blocked_plugin_names() const { Return as const-ref? https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc File ...
5 years, 9 months ago (2015-03-23 22:30:46 UTC) #14
meacer
https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/content_settings/tab_specific_content_settings.h File chrome/browser/content_settings/tab_specific_content_settings.h (right): https://codereview.chromium.org/1025503002/diff/80001/chrome/browser/content_settings/tab_specific_content_settings.h#newcode183 chrome/browser/content_settings/tab_specific_content_settings.h:183: std::vector<base::string16> blocked_plugin_names() const { On 2015/03/23 22:30:46, Bernhard Bauer ...
5 years, 9 months ago (2015-03-23 23:44:46 UTC) #15
msw
https://codereview.chromium.org/1025503002/diff/130001/chrome/browser/ui/views/content_setting_bubble_contents.cc File chrome/browser/ui/views/content_setting_bubble_contents.cc (right): https://codereview.chromium.org/1025503002/diff/130001/chrome/browser/ui/views/content_setting_bubble_contents.cc#newcode235 chrome/browser/ui/views/content_setting_bubble_contents.cc:235: list_item_links_[link] = row++; Should |row| be incremented in the ...
5 years, 9 months ago (2015-03-23 23:54:13 UTC) #16
meacer
https://codereview.chromium.org/1025503002/diff/130001/chrome/browser/ui/views/content_setting_bubble_contents.cc File chrome/browser/ui/views/content_setting_bubble_contents.cc (right): https://codereview.chromium.org/1025503002/diff/130001/chrome/browser/ui/views/content_setting_bubble_contents.cc#newcode235 chrome/browser/ui/views/content_setting_bubble_contents.cc:235: list_item_links_[link] = row++; On 2015/03/23 23:54:13, msw wrote: > ...
5 years, 9 months ago (2015-03-24 00:14:39 UTC) #17
Bernhard Bauer
https://codereview.chromium.org/1025503002/diff/150001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/1025503002/diff/150001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode421 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:421: for (const auto& listItem : listItems) { Would you ...
5 years, 9 months ago (2015-03-24 14:36:53 UTC) #18
meacer
https://codereview.chromium.org/1025503002/diff/150001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/1025503002/diff/150001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode421 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:421: for (const auto& listItem : listItems) { On 2015/03/24 ...
5 years, 9 months ago (2015-03-25 19:23:12 UTC) #19
Bernhard Bauer
LGTM, thanks!
5 years, 9 months ago (2015-03-25 21:50:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025503002/170001
5 years, 9 months ago (2015-03-25 23:49:49 UTC) #23
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years, 9 months ago (2015-03-26 01:54:18 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 01:55:17 UTC) #25
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/428eaaad7b3eb9c3221071aafe7db2bc32be1fac
Cr-Commit-Position: refs/heads/master@{#322295}

Powered by Google App Engine
This is Rietveld 408576698