Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1025463002: Sk2x (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk2x This adds an API, an SSE impl, a portable impl, and some tests for Sk2f/Sk2d/Sk2s. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bbecae0832996b72d1f6e7d39d2754651300d31e

Patch Set 1 #

Patch Set 2 : sk2s #

Patch Set 3 : if only #

Patch Set 4 : SSE impl #

Patch Set 5 : weird #

Patch Set 6 : note #

Patch Set 7 : 32-bit compat #

Patch Set 8 : (C) #

Patch Set 9 : missing inline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -0 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/Sk2x.h View 1 2 3 4 5 6 7 1 chunk +72 lines, -0 lines 0 comments Download
A src/opts/Sk2x_none.h View 1 2 3 4 5 6 7 1 chunk +66 lines, -0 lines 0 comments Download
A src/opts/Sk2x_sse.h View 1 2 3 4 5 6 7 8 1 chunk +73 lines, -0 lines 0 comments Download
A tests/Sk2xTest.cpp View 1 2 3 4 5 6 7 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
mtklein_C
5 years, 9 months ago (2015-03-19 15:56:17 UTC) #2
mtklein_C
Started work on real impls over lunch. Adding Matt for _sse.h. Also realized Cary might ...
5 years, 9 months ago (2015-03-19 16:35:03 UTC) #4
msarett
lgtm
5 years, 9 months ago (2015-03-19 16:44:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025463002/100001
5 years, 9 months ago (2015-03-19 16:47:39 UTC) #8
reed1
need copyright headers, but lgtm
5 years, 9 months ago (2015-03-19 17:16:06 UTC) #10
mtklein
On 2015/03/19 17:16:06, reed1 wrote: > need copyright headers, but lgtm done
5 years, 9 months ago (2015-03-19 17:27:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025463002/140001
5 years, 9 months ago (2015-03-19 17:28:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025463002/160001
5 years, 9 months ago (2015-03-19 17:39:15 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 17:44:31 UTC) #19
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/bbecae0832996b72d1f6e7d39d2754651300d31e

Powered by Google App Engine
This is Rietveld 408576698