Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1025453004: Reland: ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium) (Closed)

Created:
5 years, 9 months ago by kinuko
Modified:
5 years, 9 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium) * Add SWContextCore::GetProviderHostByClientID() method * Add SWContextCore::GetProviderHostIterator() which takes predicate * Make ServiceWorkerVersion::OnGetClients return uncontrolled host when * specified * Make ServiceWorkerVersion::On{PostMessage,Focus} work for uncontrolled * hosts (i.e. now ServiceWorker can have clients that are not controlled by it) Original review: https://codereview.chromium.org/1007133002/ (No changes since then) Spec links: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworker-client-query-options-dictionary https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-getall 1/2: THIS PATCH 2/2: blink patch (layout tests will be added here) BUG=455241 TEST=ServiceWorkerContextTest.GetProviderHostIterator TEST=layout tests will be added later TBR=nhiroki Committed: https://crrev.com/f996ee9f110c214eb78e88ea612ea590c609cae8 Cr-Commit-Position: refs/heads/master@{#321773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -44 lines) Patch
M content/browser/service_worker/service_worker_context_core.h View 3 chunks +18 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 7 chunks +42 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 2 chunks +75 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 4 chunks +41 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kinuko
(No changes since https://codereview.chromium.org/1007133002/)
5 years, 9 months ago (2015-03-23 13:47:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025453004/1
5 years, 9 months ago (2015-03-23 13:47:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 14:44:16 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 14:44:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f996ee9f110c214eb78e88ea612ea590c609cae8
Cr-Commit-Position: refs/heads/master@{#321773}

Powered by Google App Engine
This is Rietveld 408576698