Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: src/mips64/assembler-mips64.h

Issue 1025453003: MIPS: Fix 'MIPS: Serializer: serialize internal references via object visitor.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 inline static void deserialization_set_special_target_at( 535 inline static void deserialization_set_special_target_at(
536 Address instruction_payload, Code* code, Address target) { 536 Address instruction_payload, Code* code, Address target) {
537 set_target_address_at( 537 set_target_address_at(
538 instruction_payload - kInstructionsFor64BitConstant * kInstrSize, 538 instruction_payload - kInstructionsFor64BitConstant * kInstrSize,
539 code, 539 code,
540 target); 540 target);
541 } 541 }
542 542
543 // This sets the internal reference at the pc. 543 // This sets the internal reference at the pc.
544 inline static void deserialization_set_target_internal_reference_at( 544 inline static void deserialization_set_target_internal_reference_at(
545 Address pc, Address target); 545 Address pc, Address target,
546 RelocInfo::Mode mode = RelocInfo::INTERNAL_REFERENCE);
546 547
547 // Size of an instruction. 548 // Size of an instruction.
548 static const int kInstrSize = sizeof(Instr); 549 static const int kInstrSize = sizeof(Instr);
549 550
550 // Difference between address of current opcode and target address offset. 551 // Difference between address of current opcode and target address offset.
551 static const int kBranchPCOffset = 4; 552 static const int kBranchPCOffset = 4;
552 553
553 // Here we are patching the address in the LUI/ORI instruction pair. 554 // Here we are patching the address in the LUI/ORI instruction pair.
554 // These values are used in the serialization process and must be zero for 555 // These values are used in the serialization process and must be zero for
555 // MIPS platform, as Code, Embedded Object or External-reference pointers 556 // MIPS platform, as Code, Embedded Object or External-reference pointers
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
1165 1166
1166 // Generate the constant pool for the generated code. 1167 // Generate the constant pool for the generated code.
1167 void PopulateConstantPool(ConstantPoolArray* constant_pool); 1168 void PopulateConstantPool(ConstantPoolArray* constant_pool);
1168 1169
1169 protected: 1170 protected:
1170 // Relocation for a type-recording IC has the AST id added to it. This 1171 // Relocation for a type-recording IC has the AST id added to it. This
1171 // member variable is a way to pass the information from the call site to 1172 // member variable is a way to pass the information from the call site to
1172 // the relocation info. 1173 // the relocation info.
1173 TypeFeedbackId recorded_ast_id_; 1174 TypeFeedbackId recorded_ast_id_;
1174 1175
1176 inline static void set_target_internal_reference_encoded_at(Address pc,
1177 Address target);
1178
1175 int64_t buffer_space() const { return reloc_info_writer.pos() - pc_; } 1179 int64_t buffer_space() const { return reloc_info_writer.pos() - pc_; }
1176 1180
1177 // Decode branch instruction at pos and return branch target pos. 1181 // Decode branch instruction at pos and return branch target pos.
1178 int target_at(int pos, bool is_internal); 1182 int target_at(int pos, bool is_internal);
1179 1183
1180 // Patch branch instruction at pos to branch to given branch target pos. 1184 // Patch branch instruction at pos to branch to given branch target pos.
1181 void target_at_put(int pos, int target_pos, bool is_internal); 1185 void target_at_put(int pos, int target_pos, bool is_internal);
1182 1186
1183 // Say if we need to relocate with this mode. 1187 // Say if we need to relocate with this mode.
1184 bool MustUseReg(RelocInfo::Mode rmode); 1188 bool MustUseReg(RelocInfo::Mode rmode);
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
1434 class EnsureSpace BASE_EMBEDDED { 1438 class EnsureSpace BASE_EMBEDDED {
1435 public: 1439 public:
1436 explicit EnsureSpace(Assembler* assembler) { 1440 explicit EnsureSpace(Assembler* assembler) {
1437 assembler->CheckBuffer(); 1441 assembler->CheckBuffer();
1438 } 1442 }
1439 }; 1443 };
1440 1444
1441 } } // namespace v8::internal 1445 } } // namespace v8::internal
1442 1446
1443 #endif // V8_ARM_ASSEMBLER_MIPS_H_ 1447 #endif // V8_ARM_ASSEMBLER_MIPS_H_
OLDNEW
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698