Implement common Ozone interface for Chromecast.

Implement common Ozone interface for Chromecast.

This is a refactoring of our existing Ozone implementations to extract
the common parts: implementing the single-full-screen-window
assumption, stubbing out the bits of Ozone we don't use, and the
GPU resource relinquish logic.

Implementing Ozone for new hardware is now a lot simpler - just
implement the ChromecastEglPlatform interface.  For now, each platform
still has to define the Ozone constructor function themselves,
supplying an instance of the ChromecastEglPlatform subclass.

BUG=

Committed: https://crrev.com/d086430fe91aa75fd0cb6865f6cfb847b13719d4
Cr-Commit-Position: refs/heads/master@{#322595}

[halliwell, 2015-03-19 20:46:32]

halliwell@chromium.org changed reviewers:
+ derekjchow@chromium.org, lcwu@chromium.org

[derekjchow1, 2015-03-19 21:28:02]

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
File chromecast/ozone/surface_factory_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.cc:70:
DestroyDisplayTypeAndWindow();
Would it be reasonable to call ShutdownHardware here? This way when state_ is
FAILED, the state of egl_platform_ will always be the same (hopefully
uninitialized).

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.cc:76: state_ = FAILED;
Ditto.

[halliwell, 2015-03-19 22:21:59]

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
File chromecast/ozone/surface_factory_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.cc:70:
DestroyDisplayTypeAndWindow();
On 2015/03/19 21:28:02, derekjchow1 wrote:
> Would it be reasonable to call ShutdownHardware here? This way when state_ is
> FAILED, the state of egl_platform_ will always be the same (hopefully
> uninitialized).

We're about to terminate here (FATAL) so I'm not convinced it matters much :) 
In fact ... I'm not quite sure what the point of calling
DestroyDisplayTypeAndWindow is.

For the most part though I'm trying to keep the logic and implementation the
same as the existing one for now.  It will help to track down any problems that
come out of the refactoring.  Then there are a number of things that I'd like to
clean up beyond that.

[halliwell, 2015-03-23 23:48:20]

halliwell@chromium.org changed reviewers:
+ gusfernandez@chromium.org

[lcwu1, 2015-03-27 00:51:43]

https://codereview.chromium.org/1025453002/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:303: 'cast_ozone',
This new dependency should be in 'cast_shell_core' instead of
'cast_shell_common' which is also used by Android. (And you can see that the
dependencies on ozone and cast_gfx_internal are in 'cast_shell_core' too.)

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/chromecast...
File chromecast/ozone/chromecast_egl_platform.h (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/chromecast...
chromecast/ozone/chromecast_egl_platform.h:20: class ChromecastEglPlatform {
I would change the class name To CastEglPlatform and the file name to
cast_egl_platform.h. In fact, I think we should change the names of all the
other classes in this CL to xxxChromecast to xxxCast.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
File chromecast/ozone/ozone_platform_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
chromecast/ozone/ozone_platform_chromecast.cc:4: #include
"chromecast/ozone/ozone_platform_chromecast.h"
Add a vertical space between the header comment and the first include.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
File chromecast/ozone/ozone_platform_chromecast.h (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
chromecast/ozone/ozone_platform_chromecast.h:26:
OzonePlatformChromecast(scoped_ptr<ChromecastEglPlatform> egl_platform);
Add 'explicit' keyword.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/platform_w...
File chromecast/ozone/platform_window_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/platform_w...
chromecast/ozone/platform_window_chromecast.cc:4: #include
"chromecast/ozone/platform_window_chromecast.h"
Add a vertical space above.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
File chromecast/ozone/surface_factory_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.cc:4: #include
"chromecast/ozone/surface_factory_chromecast.h"
Add a vertical space above.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
File chromecast/ozone/surface_factory_chromecast.h (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.h:21:
SurfaceFactoryChromecast(scoped_ptr<ChromecastEglPlatform> egl_platform);
Add 'explicit'.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.h:40: enum HardwareState {
UNINITIALIZED, INITIALIZED, FAILED };
Let's place each enumerator in its own line (which is a more common style in the
codebase).

Also let's be consistent on the enumerator names. Here we have macro-like names,
but in the enum below (DestroyWindowPendingState) we have constant-like names.
Either way is fine according to the style guide, but we should be consistent.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_oz...
File chromecast/ozone/surface_ozone_egl_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_oz...
chromecast/ozone/surface_ozone_egl_chromecast.cc:4: #include
"chromecast/ozone/surface_ozone_egl_chromecast.h"
Add a vertical space above.

[halliwell, 2015-03-27 01:45:03]

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/chromecast...
File chromecast/ozone/chromecast_egl_platform.h (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/chromecast...
chromecast/ozone/chromecast_egl_platform.h:20: class ChromecastEglPlatform {
On 2015/03/27 00:51:42, lcwu1 wrote:
> I would change the class name To CastEglPlatform and the file name to
> cast_egl_platform.h. In fact, I think we should change the names of all the
> other classes in this CL to xxxChromecast to xxxCast.

Done.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
File chromecast/ozone/ozone_platform_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
chromecast/ozone/ozone_platform_chromecast.cc:4: #include
"chromecast/ozone/ozone_platform_chromecast.h"
On 2015/03/27 00:51:42, lcwu1 wrote:
> Add a vertical space between the header comment and the first include.

Done.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
File chromecast/ozone/ozone_platform_chromecast.h (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/ozone_plat...
chromecast/ozone/ozone_platform_chromecast.h:26:
OzonePlatformChromecast(scoped_ptr<ChromecastEglPlatform> egl_platform);
On 2015/03/27 00:51:42, lcwu1 wrote:
> Add 'explicit' keyword.

Done.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/platform_w...
File chromecast/ozone/platform_window_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/platform_w...
chromecast/ozone/platform_window_chromecast.cc:4: #include
"chromecast/ozone/platform_window_chromecast.h"
On 2015/03/27 00:51:42, lcwu1 wrote:
> Add a vertical space above. 

Done.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
File chromecast/ozone/surface_factory_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.cc:4: #include
"chromecast/ozone/surface_factory_chromecast.h"
On 2015/03/27 00:51:43, lcwu1 wrote:
> Add a vertical space above.

Done.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
File chromecast/ozone/surface_factory_chromecast.h (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.h:21:
SurfaceFactoryChromecast(scoped_ptr<ChromecastEglPlatform> egl_platform);
On 2015/03/27 00:51:43, lcwu1 wrote:
> Add 'explicit'.

Done.

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_fa...
chromecast/ozone/surface_factory_chromecast.h:40: enum HardwareState {
UNINITIALIZED, INITIALIZED, FAILED };
On 2015/03/27 00:51:43, lcwu1 wrote:
> Let's place each enumerator in its own line (which is a more common style in
the
> codebase).
> 
> Also let's be consistent on the enumerator names. Here we have macro-like
names,
> but in the enum below (DestroyWindowPendingState) we have constant-like names.
> Either way is fine according to the style guide, but we should be consistent.

Switching away from all-caps (I don't like that much anyway).

Keeping it on one line though for now because I just noticed 'git cl format'
puts it that way.  I don't like fighting the auto format unless there's a strong
reason :)

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_oz...
File chromecast/ozone/surface_ozone_egl_chromecast.cc (right):

https://codereview.chromium.org/1025453002/diff/1/chromecast/ozone/surface_oz...
chromecast/ozone/surface_ozone_egl_chromecast.cc:4: #include
"chromecast/ozone/surface_ozone_egl_chromecast.h"
On 2015/03/27 00:51:43, lcwu1 wrote:
> Add a vertical space above.

Done.

[lcwu1, 2015-03-27 16:30:40]

lgtm

[halliwell, 2015-03-27 16:31:17]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2015-03-27 16:31:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025453002/20001

[commit-bot: I haz the power, 2015-03-27 16:54:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-27 16:55:16]

Patchset 2 (id:??) landed as
https://crrev.com/d086430fe91aa75fd0cb6865f6cfb847b13719d4
Cr-Commit-Position: refs/heads/master@{#322595}