Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/lookup-inl.h

Issue 1025433002: Add debug checks to catch PropertyCell::cast failures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LOOKUP_INL_H_ 5 #ifndef V8_LOOKUP_INL_H_
6 #define V8_LOOKUP_INL_H_ 6 #define V8_LOOKUP_INL_H_
7 7
8 #include "src/lookup.h" 8 #include "src/lookup.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 !SkipInterceptor(JSObject::cast(holder))) { 55 !SkipInterceptor(JSObject::cast(holder))) {
56 return INTERCEPTOR; 56 return INTERCEPTOR;
57 } 57 }
58 // Fall through. 58 // Fall through.
59 case INTERCEPTOR: 59 case INTERCEPTOR:
60 if (map->is_dictionary_map()) { 60 if (map->is_dictionary_map()) {
61 NameDictionary* dict = JSObject::cast(holder)->property_dictionary(); 61 NameDictionary* dict = JSObject::cast(holder)->property_dictionary();
62 number_ = dict->FindEntry(name_); 62 number_ = dict->FindEntry(name_);
63 if (number_ == NameDictionary::kNotFound) return NOT_FOUND; 63 if (number_ == NameDictionary::kNotFound) return NOT_FOUND;
64 if (holder->IsGlobalObject()) { 64 if (holder->IsGlobalObject()) {
65 DCHECK(dict->ValueAt(number_)->IsPropertyCell());
65 PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_)); 66 PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_));
66 if (cell->value()->IsTheHole()) return NOT_FOUND; 67 if (cell->value()->IsTheHole()) return NOT_FOUND;
67 } 68 }
68 property_details_ = dict->DetailsAt(number_); 69 property_details_ = dict->DetailsAt(number_);
69 } else { 70 } else {
70 DescriptorArray* descriptors = map->instance_descriptors(); 71 DescriptorArray* descriptors = map->instance_descriptors();
71 number_ = descriptors->SearchWithCache(*name_, map); 72 number_ = descriptors->SearchWithCache(*name_, map);
72 if (number_ == DescriptorArray::kNotFound) return NOT_FOUND; 73 if (number_ == DescriptorArray::kNotFound) return NOT_FOUND;
73 property_details_ = descriptors->GetDetails(number_); 74 property_details_ = descriptors->GetDetails(number_);
74 } 75 }
(...skipping 29 matching lines...) Expand all
104 default: 105 default:
105 return NOT_FOUND; 106 return NOT_FOUND;
106 } 107 }
107 UNREACHABLE(); 108 UNREACHABLE();
108 return state_; 109 return state_;
109 } 110 }
110 } 111 }
111 } // namespace v8::internal 112 } // namespace v8::internal
112 113
113 #endif // V8_LOOKUP_INL_H_ 114 #endif // V8_LOOKUP_INL_H_
OLDNEW
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698