Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1025433002: Add debug checks to catch PropertyCell::cast failures. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add debug checks to catch PropertyCell::cast failures. R=verwaest@chromium.org Committed: https://crrev.com/87af6018249a085ec99b54990ffb93c7a1148dbd Cr-Commit-Position: refs/heads/master@{#27309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/lookup.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 9 months ago (2015-03-19 13:20:15 UTC) #1
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-19 13:22:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025433002/1
5 years, 9 months ago (2015-03-19 13:23:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:59:16 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/87af6018249a085ec99b54990ffb93c7a1148dbd Cr-Commit-Position: refs/heads/master@{#27309}
5 years, 9 months ago (2015-03-19 13:59:24 UTC) #7
Yang
5 years, 9 months ago (2015-03-20 07:16:48 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1021163002/ by yangguo@chromium.org.

The reason for reverting is: Cause to failures found..

Powered by Google App Engine
This is Rietveld 408576698