src/json-parser.h - Issue 1025333002: Acquire a lock before checking for GC interrupt in JSON parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-parser.h

Issue 1025333002: Acquire a lock before checking for GC interrupt in JSON parser. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-parser.h

diff --git a/src/json-parser.h b/src/json-parser.h

index 7cf80966dfd18d317d61c6ff2e34ee7d38c09fa3..1a9a36f283513bab2f3b72d2d6e5a78c6d0d2de8 100644

--- a/src/json-parser.h

+++ b/src/json-parser.h

@@ -262,6 +262,7 @@ Handle<Object> JsonParser<seq_one_byte>::ParseJsonValue() {

}

if (isolate_->stack_guard()->InterruptRequested()) {

+ ExecutionAccess access(isolate_);

// Avoid blocking GC in long running parser (v8:3974).

isolate_->stack_guard()->CheckAndHandleGCInterrupt();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »