Issue 102533002: Implemented DocumentType.cloneNode(bool)

Issue 102533002: Implemented DocumentType.cloneNode(bool) (Closed)

Created:
7 years ago by João Eiras

Modified:
7 years ago

Reviewers:
esprehn, abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Implemented DocumentType.cloneNode(bool) Spec: http://dom.spec.whatwg.org/#concept-node-clone BUG=325226 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164168

Patch Set 3 : addressed review issues #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -1 line)			Patch
A	LayoutTests/fast/dom/DocumentType/clone-node.html	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/DocumentType/clone-node-expected.txt	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

esprehn

https://codereview.chromium.org/102533002/diff/1/LayoutTests/fast/dom/DocumentType/clone-node.html File LayoutTests/fast/dom/DocumentType/clone-node.html (right): https://codereview.chromium.org/102533002/diff/1/LayoutTests/fast/dom/DocumentType/clone-node.html#newcode3 LayoutTests/fast/dom/DocumentType/clone-node.html:3: <link rel="help" href="http://dom.spec.whatwg.org/#dom-node-clonenode"> Just leave out the <html>, <head> ...

7 years ago (2013-12-09 17:19:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/102533002/40001

7 years ago (2013-12-19 10:28:10 UTC) #4

Message was sent while issue was closed.

Change committed as 164168

Expand Messages | Collapse Messages