Show SigninErrorController username and status in AboutSigninInternals

Show SigninErrorController username and status in AboutSigninInternals

BUG=405038
TEST=
1. Sign in to Chrome and make sure there are no Auth Errors
2. Navigate to chrome://signin-internals
3. In the Basic Information section, observe that there is no ErrorController Username or ErrorController Status section
4. Trigger an Auth Error (for example by revoking Chrome's access token at accounts.google.com)
5. In chrome://signin-internals, observe that the Basic Information section was updated with the ErrorController Username and ErrorController Status fields.

Committed: https://crrev.com/0096addf2b43be672d04cbe8ac55644fdad9d3ff
Cr-Commit-Position: refs/heads/master@{#322426}

[anthonyvd, 2015-03-25 14:41:10]

anthonyvd@chromium.org changed reviewers:
+ rogerta@chromium.org

[anthonyvd, 2015-03-25 14:41:10]

Hi Roger, can you take a look at this CL which is the first part of the
remaining signin internals work.

Thanks!

[Roger Tawa OOO till Jul 10th, 2015-03-25 15:41:55]

lgtm

Awesome, thanks Anthony.  Looks good with a couple of nits below.

https://codereview.chromium.org/1025323004/diff/1/chrome/browser/signin/about...
File chrome/browser/signin/about_signin_internals_factory.cc (right):

https://codereview.chromium.org/1025323004/diff/1/chrome/browser/signin/about...
chrome/browser/signin/about_signin_internals_factory.cc:32:
DependsOn(SigninErrorControllerFactory::GetInstance());
nit: keep in alpha order.

https://codereview.chromium.org/1025323004/diff/1/components/signin/core/brow...
File components/signin/core/browser/about_signin_internals.cc (right):

https://codereview.chromium.org/1025323004/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:224:
cookie_changed_subscription_.reset();
Remove observer here?

https://codereview.chromium.org/1025323004/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:544: }
If there is no auth error, maybe it should say:

   Auth Error: None

sort of like is done with "Signin Status" above.  If there is an auth error,
maybe it should say:

   Auth Error: <ToString() value of auth_error()>
   Auth Error Username: <value of error_username()>

Trying to avoid using class name in UI :-)

[anthonyvd, 2015-03-26 15:49:59]

https://codereview.chromium.org/1025323004/diff/1/chrome/browser/signin/about...
File chrome/browser/signin/about_signin_internals_factory.cc (right):

https://codereview.chromium.org/1025323004/diff/1/chrome/browser/signin/about...
chrome/browser/signin/about_signin_internals_factory.cc:32:
DependsOn(SigninErrorControllerFactory::GetInstance());
On 2015/03/25 15:41:55, Roger Tawa wrote:
> nit: keep in alpha order.

Done.

https://codereview.chromium.org/1025323004/diff/1/components/signin/core/brow...
File components/signin/core/browser/about_signin_internals.cc (right):

https://codereview.chromium.org/1025323004/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:224:
cookie_changed_subscription_.reset();
On 2015/03/25 15:41:55, Roger Tawa wrote:
> Remove observer here?

Done.

https://codereview.chromium.org/1025323004/diff/1/components/signin/core/brow...
components/signin/core/browser/about_signin_internals.cc:544: }
On 2015/03/25 15:41:55, Roger Tawa wrote:
> If there is no auth error, maybe it should say:
> 
>    Auth Error: None
> 
> sort of like is done with "Signin Status" above.  If there is an auth error,
> maybe it should say:
> 
>    Auth Error: <ToString() value of auth_error()>
>    Auth Error Username: <value of error_username()>
> 
> Trying to avoid using class name in UI :-)

Done. Makes sense to be consistent with Signin Status :)

[anthonyvd, 2015-03-26 17:02:03]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2015-03-26 17:02:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1025323004/#ps20001
(title: "Address feedback.")

[commit-bot: I haz the power, 2015-03-26 17:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025323004/20001

[commit-bot: I haz the power, 2015-03-26 18:21:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-26 18:22:02]

Patchset 2 (id:??) landed as
https://crrev.com/0096addf2b43be672d04cbe8ac55644fdad9d3ff
Cr-Commit-Position: refs/heads/master@{#322426}