Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1025303007: Remove PluginInstallerInfoBarDelegate (Closed)

Created:
5 years, 9 months ago by Will Harris
Modified:
5 years, 9 months ago
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PluginInstallerInfoBarDelegate With the NPAPI deprecation, there is no point prompting to install plugins. Most of the guts is left in place for the out of date plugin infobar, which is still needed. BUG=459155 TEST=Visit https://java.com/en/download/uninstallapplet.jsp and verify no install prompt appears. Committed: https://crrev.com/24f192644365a0b235111754afe496d7026f089b Cr-Commit-Position: refs/heads/master@{#322031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -289 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.h View 2 chunks +7 lines, -66 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 chunk +5 lines, -133 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +0 lines, -41 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Will Harris
PTAL
5 years, 9 months ago (2015-03-24 01:52:48 UTC) #2
Will Harris
On 2015/03/24 01:52:48, Will Harris wrote: > PTAL I'm wondering if I could further in ...
5 years, 9 months ago (2015-03-24 02:12:28 UTC) #3
Bernhard Bauer
LGTM On 2015/03/24 02:12:28, Will Harris wrote: > On 2015/03/24 01:52:48, Will Harris wrote: > ...
5 years, 9 months ago (2015-03-24 08:49:00 UTC) #4
Will Harris
+fsamuel for chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
5 years, 9 months ago (2015-03-24 18:09:30 UTC) #6
Fady Samuel
web_view lgtm
5 years, 9 months ago (2015-03-24 18:11:20 UTC) #7
Will Harris
thanks both of you for the quick reviews!
5 years, 9 months ago (2015-03-24 18:14:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025303007/1
5 years, 9 months ago (2015-03-24 18:14:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 18:19:12 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 18:19:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24f192644365a0b235111754afe496d7026f089b
Cr-Commit-Position: refs/heads/master@{#322031}

Powered by Google App Engine
This is Rietveld 408576698