Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1025303003: [Extensions Toolbar Mac] Adjust equality comparisons in container code (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Mac] Adjust equality comparisons in container code Adjust from using strict equality to >= and <= in order to account for the possibility of ratios and floats more safely. BUG=463905 Committed: https://crrev.com/608c0ac5cfa5950fad5373664ff578ebcd423bce Cr-Commit-Position: refs/heads/master@{#321834}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Devlin
Addressing comment from https://codereview.chromium.org/1009613002/ https://codereview.chromium.org/1025303003/diff/1/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm (right): https://codereview.chromium.org/1025303003/diff/1/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm#newcode206 chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:206: grippyPinned_ = width == maxAllowedWidth; ...
5 years, 9 months ago (2015-03-23 18:19:13 UTC) #2
Scott Hess - ex-Googler
lgtm
5 years, 9 months ago (2015-03-23 19:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025303003/1
5 years, 9 months ago (2015-03-23 19:14:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 19:53:19 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 19:55:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/608c0ac5cfa5950fad5373664ff578ebcd423bce
Cr-Commit-Position: refs/heads/master@{#321834}

Powered by Google App Engine
This is Rietveld 408576698