Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: lib/ports.dart

Issue 1025293003: pkg/isolate: library renaming, removed unused method, fix creation of TimeoutException (Closed) Base URL: https://github.com/dart-lang/isolate.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/ports.dart
diff --git a/lib/ports.dart b/lib/ports.dart
index a007ff3f366a99cd02b15cfdc672c813dab69361..102dd06752bbbfe9750d341f381fdb978ca6c6bc 100644
--- a/lib/ports.dart
+++ b/lib/ports.dart
@@ -17,10 +17,11 @@
///
/// Other functions intercept the returned value and either
/// does something with it, or puts it into a [Future] or [Completer].
-library dart.pkg.isolate.ports;
+library isolate.ports;
-import "dart:isolate";
import "dart:async";
+import "dart:isolate";
+
import "src/lists.dart";
/// Create a [SendPort] that accepts only one message.
@@ -299,7 +300,8 @@ class SingleResponseChannel {
_receivePort.close();
if (!_completer.isCompleted) {
if (throwOnTimeout) {
- _completer.completeError(new TimeoutException(timeout));
+ _completer.completeError(
+ new TimeoutException('Timeout waiting for response, timeout'));
Lasse Reichstein Nielsen 2015/03/24 10:35:38 I think "timeout" should be the second argument, n
kevmoo 2015/03/24 13:21:19 Done.
} else if (onTimeout != null) {
_completer.complete(new Future.sync(onTimeout));
} else {

Powered by Google App Engine
This is Rietveld 408576698