Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Side by Side Diff: Source/core/layout/LayoutTableSection.cpp

Issue 1025213002: Begin tracking why layout is invalidated (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutTableCol.cpp ('k') | Source/core/layout/LayoutText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1387 matching lines...) Expand 10 before | Expand all | Expand 10 after
1398 1398
1399 m_grid[insertionRow].rowRenderer = row; 1399 m_grid[insertionRow].rowRenderer = row;
1400 row->setRowIndex(insertionRow); 1400 row->setRowIndex(insertionRow);
1401 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[insertionRow]); 1401 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[insertionRow]);
1402 1402
1403 for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCe ll()) 1403 for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCe ll())
1404 addCell(cell, row); 1404 addCell(cell, row);
1405 } 1405 }
1406 1406
1407 m_grid.shrinkToFit(); 1407 m_grid.shrinkToFit();
1408 setNeedsLayoutAndFullPaintInvalidation(); 1408 setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::Unknown);
1409 } 1409 }
1410 1410
1411 // FIXME: This function could be made O(1) in certain cases (like for the non-mo st-constrainive cells' case). 1411 // FIXME: This function could be made O(1) in certain cases (like for the non-mo st-constrainive cells' case).
1412 void LayoutTableSection::rowLogicalHeightChanged(LayoutTableRow* row) 1412 void LayoutTableSection::rowLogicalHeightChanged(LayoutTableRow* row)
1413 { 1413 {
1414 if (needsCellRecalc()) 1414 if (needsCellRecalc())
1415 return; 1415 return;
1416 1416
1417 unsigned rowIndex = row->rowIndex(); 1417 unsigned rowIndex = row->rowIndex();
1418 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[rowIndex]); 1418 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[rowIndex]);
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1608 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691). 1608 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691).
1609 if (!style()->isLeftToRightDirection()) 1609 if (!style()->isLeftToRightDirection())
1610 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing); 1610 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing);
1611 else 1611 else
1612 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing); 1612 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing);
1613 1613
1614 cell->setLogicalLocation(cellLocation); 1614 cell->setLogicalLocation(cellLocation);
1615 } 1615 }
1616 1616
1617 } // namespace blink 1617 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTableCol.cpp ('k') | Source/core/layout/LayoutText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698