Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 1025213002: Begin tracking why layout is invalidated (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1587 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 if (!newPseudoStyle) 1598 if (!newPseudoStyle)
1599 return true; 1599 return true;
1600 if (*newPseudoStyle != *pseudoStyleCache->at(i)) { 1600 if (*newPseudoStyle != *pseudoStyleCache->at(i)) {
1601 if (pseudoId < FIRST_INTERNAL_PSEUDOID) 1601 if (pseudoId < FIRST_INTERNAL_PSEUDOID)
1602 newStyle->setHasPseudoStyle(pseudoId); 1602 newStyle->setHasPseudoStyle(pseudoId);
1603 newStyle->addCachedPseudoStyle(newPseudoStyle); 1603 newStyle->addCachedPseudoStyle(newPseudoStyle);
1604 if (pseudoId == FIRST_LINE || pseudoId == FIRST_LINE_INHERITED) { 1604 if (pseudoId == FIRST_LINE || pseudoId == FIRST_LINE_INHERITED) {
1605 // FIXME: We should do an actual diff to determine whether a rep aint vs. layout 1605 // FIXME: We should do an actual diff to determine whether a rep aint vs. layout
1606 // is needed, but for now just assume a layout will be required. The diff code 1606 // is needed, but for now just assume a layout will be required. The diff code
1607 // in LayoutObject::setStyle would need to be factored out so th at it could be reused. 1607 // in LayoutObject::setStyle would need to be factored out so th at it could be reused.
1608 layoutObject()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInv alidation(); 1608 layoutObject()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInv alidation(LayoutInvalidationReason::StyleChange);
1609 } 1609 }
1610 return true; 1610 return true;
1611 } 1611 }
1612 } 1612 }
1613 return false; 1613 return false;
1614 } 1614 }
1615 1615
1616 PassRefPtr<ComputedStyle> Element::styleForLayoutObject() 1616 PassRefPtr<ComputedStyle> Element::styleForLayoutObject()
1617 { 1617 {
1618 ASSERT(document().inStyleRecalc()); 1618 ASSERT(document().inStyleRecalc());
(...skipping 1876 matching lines...) Expand 10 before | Expand all | Expand 10 after
3495 { 3495 {
3496 #if ENABLE(OILPAN) 3496 #if ENABLE(OILPAN)
3497 if (hasRareData()) 3497 if (hasRareData())
3498 visitor->trace(elementRareData()); 3498 visitor->trace(elementRareData());
3499 visitor->trace(m_elementData); 3499 visitor->trace(m_elementData);
3500 #endif 3500 #endif
3501 ContainerNode::trace(visitor); 3501 ContainerNode::trace(visitor);
3502 } 3502 }
3503 3503
3504 } // namespace blink 3504 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698