Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/layout/LayoutTableSection.cpp

Issue 1025213002: Begin tracking why layout is invalidated (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1383 matching lines...) Expand 10 before | Expand all | Expand 10 after
1394 1394
1395 m_grid[insertionRow].rowRenderer = row; 1395 m_grid[insertionRow].rowRenderer = row;
1396 row->setRowIndex(insertionRow); 1396 row->setRowIndex(insertionRow);
1397 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[insertionRow]); 1397 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[insertionRow]);
1398 1398
1399 for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCe ll()) 1399 for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCe ll())
1400 addCell(cell, row); 1400 addCell(cell, row);
1401 } 1401 }
1402 1402
1403 m_grid.shrinkToFit(); 1403 m_grid.shrinkToFit();
1404 setNeedsLayoutAndFullPaintInvalidation(); 1404 setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::Unknown);
1405 } 1405 }
1406 1406
1407 // FIXME: This function could be made O(1) in certain cases (like for the non-mo st-constrainive cells' case). 1407 // FIXME: This function could be made O(1) in certain cases (like for the non-mo st-constrainive cells' case).
1408 void LayoutTableSection::rowLogicalHeightChanged(LayoutTableRow* row) 1408 void LayoutTableSection::rowLogicalHeightChanged(LayoutTableRow* row)
1409 { 1409 {
1410 if (needsCellRecalc()) 1410 if (needsCellRecalc())
1411 return; 1411 return;
1412 1412
1413 unsigned rowIndex = row->rowIndex(); 1413 unsigned rowIndex = row->rowIndex();
1414 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[rowIndex]); 1414 setRowLogicalHeightToRowStyleLogicalHeight(m_grid[rowIndex]);
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691). 1604 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691).
1605 if (!style()->isLeftToRightDirection()) 1605 if (!style()->isLeftToRightDirection())
1606 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing); 1606 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing);
1607 else 1607 else
1608 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing); 1608 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing);
1609 1609
1610 cell->setLogicalLocation(cellLocation); 1610 cell->setLogicalLocation(cellLocation);
1611 } 1611 }
1612 1612
1613 } // namespace blink 1613 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698