Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1025163002: Rename AlsaRawmidi to AlsaCard and include the count of midi devices instead of duplicating (Closed)

Created:
5 years, 9 months ago by Adam Goode
Modified:
5 years, 9 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@h4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename AlsaRawmidi to AlsaCard and include the count of midi devices instead of duplicating BUG=431489 Committed: https://crrev.com/9c314a44b59feb7cbaa544bf89ca83b8780261a0 Cr-Commit-Position: refs/heads/master@{#322022}

Patch Set 1 #

Patch Set 2 : Rename AllAlsaCards to AllMidiCards to be more clear #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -63 lines) Patch
M media/midi/midi_manager_alsa.h View 1 4 chunks +13 lines, -10 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 10 chunks +50 lines, -37 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 1 chunk +15 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Adam Goode
5 years, 9 months ago (2015-03-24 13:31:29 UTC) #3
Takashi Toyoshima
lgtm
5 years, 9 months ago (2015-03-24 17:15:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025163002/40001
5 years, 9 months ago (2015-03-24 17:20:25 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 17:23:56 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 17:24:36 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9c314a44b59feb7cbaa544bf89ca83b8780261a0
Cr-Commit-Position: refs/heads/master@{#322022}

Powered by Google App Engine
This is Rietveld 408576698