Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1025153002: tools/gn: make defined(foo.bar) an error if !defined(foo) (Closed)

Created:
5 years, 9 months ago by mdempsky
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: make defined(foo.bar) an error if !defined(foo) Users must now write "defined(foo) && defined(foo.bar)" if they want the old semantics. No Chromium BUILD.gn files were harmed in the making of this CL. Committed: https://crrev.com/365796868448a3983a5831abdc37f67588390dde Cr-Commit-Position: refs/heads/master@{#321808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M tools/gn/functions.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdempsky
5 years, 9 months ago (2015-03-21 23:51:54 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-03-23 17:22:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025153002/1
5 years, 9 months ago (2015-03-23 17:27:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 18:14:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:15:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/365796868448a3983a5831abdc37f67588390dde
Cr-Commit-Position: refs/heads/master@{#321808}

Powered by Google App Engine
This is Rietveld 408576698