Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 1025133003: Oilpan: remove now-addressed PostMessageTimer fixme. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 private: 183 private:
184 virtual void fired() override 184 virtual void fired() override
185 { 185 {
186 InspectorInstrumentationCookie cookie = InspectorInstrumentation::traceA syncOperationCompletedCallbackStarting(executionContext(), m_asyncOperationId); 186 InspectorInstrumentationCookie cookie = InspectorInstrumentation::traceA syncOperationCompletedCallbackStarting(executionContext(), m_asyncOperationId);
187 m_window->postMessageTimerFired(this); 187 m_window->postMessageTimerFired(this);
188 // This object is deleted now. 188 // This object is deleted now.
189 InspectorInstrumentation::traceAsyncCallbackCompleted(cookie); 189 InspectorInstrumentation::traceAsyncCallbackCompleted(cookie);
190 } 190 }
191 191
192 // FIXME: Oilpan: This raw pointer is safe because the PostMessageTimer is
193 // owned by the LocalDOMWindow. Ideally PostMessageTimer should be moved to
194 // the heap and use Member<LocalDOMWindow>.
195 RawPtrWillBeMember<LocalDOMWindow> m_window; 192 RawPtrWillBeMember<LocalDOMWindow> m_window;
196 RefPtr<SerializedScriptValue> m_message; 193 RefPtr<SerializedScriptValue> m_message;
197 String m_origin; 194 String m_origin;
198 RefPtrWillBeMember<LocalDOMWindow> m_source; 195 RefPtrWillBeMember<LocalDOMWindow> m_source;
199 OwnPtr<MessagePortChannelArray> m_channels; 196 OwnPtr<MessagePortChannelArray> m_channels;
200 RefPtr<SecurityOrigin> m_targetOrigin; 197 RefPtr<SecurityOrigin> m_targetOrigin;
201 RefPtrWillBeMember<ScriptCallStack> m_stackTrace; 198 RefPtrWillBeMember<ScriptCallStack> m_stackTrace;
202 RefPtr<UserGestureToken> m_userGestureToken; 199 RefPtr<UserGestureToken> m_userGestureToken;
203 int m_asyncOperationId; 200 int m_asyncOperationId;
204 }; 201 };
(...skipping 1552 matching lines...) Expand 10 before | Expand all | Expand 10 after
1757 return m_frameObserver->frame(); 1754 return m_frameObserver->frame();
1758 } 1755 }
1759 1756
1760 v8::Handle<v8::Object> LocalDOMWindow::wrap(v8::Handle<v8::Object> creationConte xt, v8::Isolate* isolate) 1757 v8::Handle<v8::Object> LocalDOMWindow::wrap(v8::Handle<v8::Object> creationConte xt, v8::Isolate* isolate)
1761 { 1758 {
1762 ASSERT_NOT_REACHED(); // LocalDOMWindow has [Custom=ToV8]. 1759 ASSERT_NOT_REACHED(); // LocalDOMWindow has [Custom=ToV8].
1763 return v8::Handle<v8::Object>(); 1760 return v8::Handle<v8::Object>();
1764 } 1761 }
1765 1762
1766 } // namespace blink 1763 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698