Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 1025133002: Revert of Make the simple QUIC client able to resolve hosts. (Closed)

Created:
5 years, 9 months ago by pfeldman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make the simple QUIC client able to resolve hosts. (patchset #7 id:120001 of https://codereview.chromium.org/1004173004/) Reason for revert: Build failure: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/7147/steps/compile/logs/stdio Original issue's description: > Make the simple QUIC client able to resolve hosts. > Implement a SynchronousHostResolver for this purpose. > > Committed: https://crrev.com/acfb2f91085d5291ba1c9a04dbe7aea610b13e33 > Cr-Commit-Position: refs/heads/master@{#321688} TBR=rtenneti@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ca74cd29f03fe4c114a4fcad3efef7b3496d95f8 Cr-Commit-Position: refs/heads/master@{#321702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -165 lines) Patch
M net/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 3 chunks +5 lines, -12 lines 0 comments Download
D net/tools/quic/synchronous_host_resolver.h View 1 chunk +0 lines, -26 lines 0 comments Download
D net/tools/quic/synchronous_host_resolver.cc View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
Created Revert of Make the simple QUIC client able to resolve hosts.
5 years, 9 months ago (2015-03-21 13:15:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025133002/1
5 years, 9 months ago (2015-03-21 13:15:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-21 13:16:12 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-21 13:16:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca74cd29f03fe4c114a4fcad3efef7b3496d95f8
Cr-Commit-Position: refs/heads/master@{#321702}

Powered by Google App Engine
This is Rietveld 408576698