Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1025073005: X87: Use platform specific stubs for vector-based Load/KeyedLoad. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use platform specific stubs for vector-based Load/KeyedLoad. port 34a1a76ddf30109f7b6cb60aa2651493ab38660a (r27235) original commit message: A hydrogen code stub is not the best approach because it builds a frame and doesn't have the technology to discard roots at tail call exits. Platform-specific stubs provide much better performance at this point. BUG= Committed: https://crrev.com/40de9c3f02d9659b83f3fa5340132adf54e50223 Cr-Commit-Position: refs/heads/master@{#27394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -4 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +226 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 10:06:47 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-24 09:46:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025073005/1
5 years, 9 months ago (2015-03-24 09:47:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 10:06:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 10:06:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40de9c3f02d9659b83f3fa5340132adf54e50223
Cr-Commit-Position: refs/heads/master@{#27394}

Powered by Google App Engine
This is Rietveld 408576698