Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: sky/engine/core/script/dart_loader.cc

Issue 1025073003: Add more tracing to Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/script/dart_controller.cc ('k') | sky/shell/ui/animator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/script/dart_loader.cc
diff --git a/sky/engine/core/script/dart_loader.cc b/sky/engine/core/script/dart_loader.cc
index 9ae0a3e9b9dca3217af4c95e71e241b473253cec..9f6418167ec2aa7f2f7a705a8566f8302c9a1fb9 100644
--- a/sky/engine/core/script/dart_loader.cc
+++ b/sky/engine/core/script/dart_loader.cc
@@ -6,6 +6,7 @@
#include "sky/engine/core/script/dart_loader.h"
#include "base/callback.h"
+#include "base/trace_event/trace_event.h"
#include "mojo/common/data_pipe_drainer.h"
#include "sky/engine/core/script/dart_dependency_catcher.h"
#include "sky/engine/core/script/dom_dart_state.h"
@@ -79,11 +80,16 @@ class DartLoader::Job : public DartDependency,
class DartLoader::ImportJob : public Job {
public:
- using Job::Job;
+ ImportJob(DartLoader* loader, const KURL& url)
+ : Job(loader, url) {
+ TRACE_EVENT_ASYNC_BEGIN1("sky", "DartLoader::ImportJob", this,
+ "url", url.string().ascii().toStdString());
+ }
private:
// DataPipeDrainer::Client
void OnDataComplete() override {
+ TRACE_EVENT_ASYNC_END0("sky", "DartLoader::ImportJob", this);
loader_->DidCompleteImportJob(this, buffer_);
}
};
@@ -91,13 +97,17 @@ class DartLoader::ImportJob : public Job {
class DartLoader::SourceJob : public Job {
public:
SourceJob(DartLoader* loader, const KURL& url, Dart_Handle library)
- : Job(loader, url), library_(loader->dart_state(), library) {}
+ : Job(loader, url), library_(loader->dart_state(), library) {
+ TRACE_EVENT_ASYNC_BEGIN1("sky", "DartLoader::SourceJob", this,
+ "url", url.string().ascii().toStdString());
+ }
Dart_PersistentHandle library() const { return library_.value(); }
private:
// DataPipeDrainer::Client
void OnDataComplete() override {
+ TRACE_EVENT_ASYNC_END0("sky", "DartLoader::SourceJob", this);
loader_->DidCompleteSourceJob(this, buffer_);
}
« no previous file with comments | « sky/engine/core/script/dart_controller.cc ('k') | sky/shell/ui/animator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698