Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1025073003: Add more tracing to Sky (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add more tracing to Sky This CL adds trace events: 1) Between requesting a frame and begin frame. 2) In the DartLoader see network latency. 3) While executing |main| and |_init|. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46a577a1fd20503c0d77dc3aecf5baf8b40c52e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M sky/engine/core/script/dart_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_loader.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M sky/shell/ui/animator.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-20 23:11:25 UTC) #1
abarth-chromium
5 years, 9 months ago (2015-03-20 23:11:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46a577a1fd20503c0d77dc3aecf5baf8b40c52e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698