Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 1025073002: Remove unowned histograms from HttpStreamFactoryImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index b2efe26432695025f3ac6f264772d9d06fc7130d..95999038b0b6b575d5e38b899cb034857d7df053 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -1013,8 +1013,6 @@ int HttpStreamFactoryImpl::Job::DoInitConnectionComplete(int result) {
establishing_tunnel_ = false;
if (connection_->socket()) {
- LogHttpConnectedMetrics(*connection_);
-
// We officially have a new connection. Record the type.
if (!connection_->is_reused()) {
ConnectionType type = using_spdy_ ? CONNECTION_SPDY : CONNECTION_HTTP;
@@ -1420,39 +1418,6 @@ void HttpStreamFactoryImpl::Job::SwitchToSpdyMode() {
using_spdy_ = true;
}
-// static
-void HttpStreamFactoryImpl::Job::LogHttpConnectedMetrics(
- const ClientSocketHandle& handle) {
- UMA_HISTOGRAM_ENUMERATION("Net.HttpSocketType", handle.reuse_type(),
- ClientSocketHandle::NUM_TYPES);
-
- switch (handle.reuse_type()) {
- case ClientSocketHandle::UNUSED:
- UMA_HISTOGRAM_CUSTOM_TIMES("Net.HttpConnectionLatency",
- handle.setup_time(),
- base::TimeDelta::FromMilliseconds(1),
- base::TimeDelta::FromMinutes(10),
- 100);
- break;
- case ClientSocketHandle::UNUSED_IDLE:
- UMA_HISTOGRAM_CUSTOM_TIMES("Net.SocketIdleTimeBeforeNextUse_UnusedSocket",
- handle.idle_time(),
- base::TimeDelta::FromMilliseconds(1),
- base::TimeDelta::FromMinutes(6),
- 100);
- break;
- case ClientSocketHandle::REUSED_IDLE:
- UMA_HISTOGRAM_CUSTOM_TIMES("Net.SocketIdleTimeBeforeNextUse_ReusedSocket",
- handle.idle_time(),
- base::TimeDelta::FromMilliseconds(1),
- base::TimeDelta::FromMinutes(6),
- 100);
- break;
- default:
- NOTREACHED();
- break;
- }
-}
mmenke 2015/03/25 15:01:52 nit: Remove extra line break.
rkaplow 2015/03/25 15:36:10 Done.
bool HttpStreamFactoryImpl::Job::IsPreconnecting() const {
DCHECK_GE(num_streams_, 0);
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698