Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1025073002: Remove unowned histograms from HttpStreamFactoryImpl. (Closed)

Created:
5 years, 9 months ago by rkaplow
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unowned histograms from HttpStreamFactoryImpl. This is related to https://codereview.chromium.org/1027693004/ and should be submitted before (although doesn't matter much). This obsoletes the unowned: Net.HttpSocketType Net.HttpConnectionLatency and removes writing to: Net.SocketIdleTimeBeforeNextUse_UnusedSocket Net.SocketIdleTimeBeforeNextUse_ReusedSocket which were made obsolete in https://codereview.chromium.org/1027693004/ Are any of these histograms being looked at? BUG=469288 Committed: https://crrev.com/ba9976a1d4b7bd92078b9266f2e3c04c28bee93a Cr-Commit-Position: refs/heads/master@{#322174}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -36 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 2 chunks +0 lines, -36 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
rkaplow
cbentzel@chromium.org: Please review changes in isherman@chromium.org: Please review changes in
5 years, 9 months ago (2015-03-20 22:05:10 UTC) #2
Ilya Sherman
histograms.xml LGTM. Thanks for the cleanup, Rob.
5 years, 9 months ago (2015-03-20 22:06:07 UTC) #3
rkaplow
5 years, 9 months ago (2015-03-23 15:52:51 UTC) #5
rkaplow
On 2015/03/23 15:52:51, rkaplow wrote: Is there a better person to review this CL?
5 years, 9 months ago (2015-03-24 14:49:40 UTC) #6
cbentzel
LGTM Sorry for delay, at external conference this week.
5 years, 9 months ago (2015-03-25 14:42:56 UTC) #7
mmenke
Quick nit. Also sorry for not responding to these...Wanted to make sure none of the ...
5 years, 9 months ago (2015-03-25 15:01:52 UTC) #8
rkaplow
On 2015/03/25 15:01:52, mmenke wrote: > Quick nit. Also sorry for not responding to these...Wanted ...
5 years, 9 months ago (2015-03-25 15:36:02 UTC) #9
rkaplow
https://codereview.chromium.org/1025073002/diff/1/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/1025073002/diff/1/net/http/http_stream_factory_impl_job.cc#newcode1421 net/http/http_stream_factory_impl_job.cc:1421: On 2015/03/25 15:01:52, mmenke wrote: > nit: Remove extra ...
5 years, 9 months ago (2015-03-25 15:36:10 UTC) #10
mmenke
Oh, and this LGTM
5 years, 9 months ago (2015-03-25 15:42:22 UTC) #11
rkaplow
On 2015/03/25 15:42:22, mmenke wrote: > Oh, and this LGTM great. thanks for both LGTMs. ...
5 years, 9 months ago (2015-03-25 15:46:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025073002/20001
5 years, 9 months ago (2015-03-25 15:46:41 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 16:43:44 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 16:45:14 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba9976a1d4b7bd92078b9266f2e3c04c28bee93a
Cr-Commit-Position: refs/heads/master@{#322174}

Powered by Google App Engine
This is Rietveld 408576698