Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1025033004: Regenerate some test cases for origin/master. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Regenerate some test cases for origin/master. Looks like these may have been generated on origin/xfa and produce different results. This needs to be corrected before xfa hits. R=thestig@chromium.org Committed: 427d223363ec7380c4be4b782d2e0c675d05263f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M fx/action/all_trigger_alert_expected.pdf.0.png View Binary file 0 comments Download
M fx/action/all_trigger_browsefordoc_expected.pdf.0.png View Binary file 0 comments Download
M fx/action/all_trigger_mailmsg_expected.pdf.0.png View Binary file 0 comments Download
M fx/action/all_trigger_newdoc_expected.pdf.0.png View Binary file 0 comments Download
M fx/action/all_trigger_print_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/calcorderindex_test_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/calculate_order_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/combo_box_expected.pdf.1.png View Binary file 0 comments Download
M fx/form/formfeild_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/js_calculate_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/list_box_expected.pdf.1.png View Binary file 0 comments Download
M fx/form/number_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/push_button_expected.pdf.1.png View Binary file 0 comments Download
M fx/form/push_button_expected.pdf.2.png View Binary file 0 comments Download
M fx/form/signature_4_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/signature_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/text_field_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/text_field_expected.pdf.1.png View Binary file 0 comments Download
M fx/js/javascriptaction_expected.pdf.0.png View Binary file 0 comments Download
M fx/js/test_app_beep_expected.pdf.0.png View Binary file 0 comments Download
M fx/js/test_control_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/1/1_10_watermark_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/1/1_1_textbox_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/1/1_2_typewriter_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/1/1_3_callout_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/2/2_6_textbox_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/3/3_4_textbox_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/fillform_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_action_trigger_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_button_sign_url_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_combo_sign_url_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_combobox0_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_combobox_actioin_goto_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_combobox_date1_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_combobox_importform_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_combobox_resetform_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_list1_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_list_expected.pdf.0.png View Binary file 0 comments Download
M fx/new/form/form_text_sign_url_expected.pdf.0.png View Binary file 0 comments Download
M fx/other/3bigpreview_expected.pdf.0.png View Binary file 0 comments Download
M fx/text/050_extra_m_expected.pdf.0.png View Binary file 0 comments Download
M fx/text/ch_1_expected.pdf.0.png View Binary file 0 comments Download
M fx/text/test_m_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Sepez
Lei, please review. Looks like I was having a bad day yesterday from a multi-tasking ...
5 years, 9 months ago (2015-03-20 20:28:26 UTC) #1
Lei Zhang
I spot checked and the majority looks more correct in the new version. fx/form/list_box_expected.pdf.1.png is ...
5 years, 9 months ago (2015-03-20 21:14:19 UTC) #2
Tom Sepez
On 2015/03/20 21:14:19, Lei Zhang wrote: > I spot checked and the majority looks more ...
5 years, 9 months ago (2015-03-20 21:21:45 UTC) #3
Tom Sepez
> > fx/form/list_box_expected.pdf.1.png is one where I can't eyeball the > difference. using the image ...
5 years, 9 months ago (2015-03-20 21:35:02 UTC) #4
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-20 21:38:07 UTC) #5
Tom Sepez
5 years, 9 months ago (2015-03-20 22:11:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
427d223363ec7380c4be4b782d2e0c675d05263f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698