Regenerate some test cases for origin/master.
Looks like these may have been generated on origin/xfa and produce
different results. This needs to be corrected before xfa hits.
R=thestig@chromium.org
Committed: 427d223363ec7380c4be4b782d2e0c675d05263f
Lei, please review. Looks like I was having a bad day yesterday from a multi-tasking ...
5 years, 9 months ago
(2015-03-20 20:28:26 UTC)
#1
Lei, please review. Looks like I was having a bad day yesterday from a
multi-tasking perspective :(
Lei Zhang
I spot checked and the majority looks more correct in the new version. fx/form/list_box_expected.pdf.1.png is ...
5 years, 9 months ago
(2015-03-20 21:14:19 UTC)
#2
I spot checked and the majority looks more correct in the new version.
fx/form/list_box_expected.pdf.1.png is one where I can't eyeball the difference.
Does the two branches have some different hinting due to diffences in freetype,
or something?
Tom Sepez
On 2015/03/20 21:14:19, Lei Zhang wrote: > I spot checked and the majority looks more ...
5 years, 9 months ago
(2015-03-20 21:21:45 UTC)
#3
On 2015/03/20 21:14:19, Lei Zhang wrote:
> I spot checked and the majority looks more correct in the new version.
> fx/form/list_box_expected.pdf.1.png is one where I can't eyeball the
difference.
> Does the two branches have some different hinting due to diffences in
freetype,
> or something?
Not sure. I've sent email to foxit asking them to explain it themselves.
Tom Sepez
> > fx/form/list_box_expected.pdf.1.png is one where I can't eyeball the > difference. using the image ...
5 years, 9 months ago
(2015-03-20 21:35:02 UTC)
#4
> > fx/form/list_box_expected.pdf.1.png is one where I can't eyeball the
> difference.
using the image diff utility, we see that there is difference in the spacing of
"t e s t 1" and "test 1" in the rightmost box in the second row from the top.
Lei Zhang
lgtm
5 years, 9 months ago
(2015-03-20 21:38:07 UTC)
#5
lgtm
Tom Sepez
Committed patchset #1 (id:1) manually as 427d223363ec7380c4be4b782d2e0c675d05263f (presubmit successful).
5 years, 9 months ago
(2015-03-20 22:11:37 UTC)
#6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
427d223363ec7380c4be4b782d2e0c675d05263f (presubmit successful).
Issue 1025033004: Regenerate some test cases for origin/master.
(Closed)
Created 5 years, 9 months ago by Tom Sepez
Modified 5 years, 9 months ago
Reviewers: Lei Zhang
Base URL: https://pdfium.googlesource.com/pdfium_tests@master
Comments: 0