Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1025033002: use Sk2s for conics (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -35 lines) Patch
M bench/PathBench.cpp View 2 chunks +71 lines, -9 lines 0 comments Download
M src/core/SkGeometry.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 6 chunks +135 lines, -26 lines 0 comments Download
M tests/GeometryTest.cpp View 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
5 years, 9 months ago (2015-03-20 20:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025033002/1
5 years, 9 months ago (2015-03-20 20:14:41 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-20 20:14:42 UTC) #5
caryclark
lgtm
5 years, 9 months ago (2015-03-20 20:21:16 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 20:23:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b640203cd5733aaf110277e28e22007c5b541565

Powered by Google App Engine
This is Rietveld 408576698