Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 1025003002: Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (Closed)

Created:
5 years, 9 months ago by tommi (sloooow) - chröme
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1008023002/) Reason for revert: See if this caused errors on Android. Original issue's description: > Clean up libjingle.gyp and remove references to libpeer_target_type. > This variable isn't supported any longer. > > BUG=446865 > > Committed: https://crrev.com/fd22585c501bdd46f0a511fa5346fc9be1b85f88 > Cr-Commit-Position: refs/heads/master@{#321371} TBR=kjellander@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446865 Committed: https://crrev.com/5e83cd0937a248f3d544800797b0dcbcba6eb13b Cr-Commit-Position: refs/heads/master@{#321614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -6 lines) Patch
M third_party/libjingle/libjingle.gyp View 6 chunks +62 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tommi (sloooow) - chröme
Created Revert of Clean up libjingle.gyp and remove references to libpeer_target_type.
5 years, 9 months ago (2015-03-20 19:27:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025003002/1
5 years, 9 months ago (2015-03-20 19:28:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 19:29:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e83cd0937a248f3d544800797b0dcbcba6eb13b Cr-Commit-Position: refs/heads/master@{#321614}
5 years, 9 months ago (2015-03-20 19:30:28 UTC) #4
kjellander_chromium
On 2015/03/20 19:30:28, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 9 months ago (2015-03-22 15:57:21 UTC) #5
tommi (sloooow) - chröme
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1007063003/ by tommi@chromium.org. ...
5 years, 9 months ago (2015-03-25 20:38:05 UTC) #6
kjellander_chromium
5 years, 9 months ago (2015-03-25 20:51:59 UTC) #7
Message was sent while issue was closed.
On 2015/03/25 20:38:05, tommi wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1007063003/ by mailto:tommi@chromium.org.
> 
> The reason for reverting is: Relanding libjingle.gyp update that removes
> libpeer_target_type references.  The issue on Android has been fixed..

Great, then this old revert lgtm

Powered by Google App Engine
This is Rietveld 408576698