Upstream VariationsSession

Upstream VariationsSession

BUG=428904
Committed: https://crrev.com/82af6f6b968a2683de21c8dc81cf1fd72bec0322
Cr-Commit-Position: refs/heads/master@{#321891}

[pkotwicz, 2015-03-20 23:25:00]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-03-20 23:26:33]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2015-03-20 23:26:34]

yfriedman@ PTAL

[Yaron, 2015-03-23 14:10:17]

yfriedman@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Yaron, 2015-03-23 14:10:17]

+asvitkine

https://codereview.chromium.org/1024993003/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1024993003/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:1640:
'android/java/src/org/chromium/chrome/browser/metrics/VariationsSession.java',
Looks like this file was dropped from the patchset.

[pkotwicz, 2015-03-23 14:34:49]

Yaron can you please take another look?

Thanks! I have added the file to the patch set.

[Yaron, 2015-03-23 14:39:44]

https://codereview.chromium.org/1024993003/diff/40001/chrome/browser/android/...
File chrome/browser/android/metrics/VariationsSession.java (right):

https://codereview.chromium.org/1024993003/diff/40001/chrome/browser/android/...
chrome/browser/android/metrics/VariationsSession.java:13: public class
VariationsSession {
You don't want this one. Only the one in the other location.

[pkotwicz, 2015-03-23 17:52:46]

Yaron, I don't understand your comment. Can you ping me offline to explain when
you have the time?

[pkotwicz, 2015-03-23 18:51:14]

Sorry, I now noticed the duplicate. I have removed it.

[Yaron, 2015-03-23 19:00:53]

lgtm

[pkotwicz, 2015-03-23 19:26:08]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2015-03-23 19:26:29]

dfalcantara@ can you please take a look? asvitkine@ seems to be OOO

[gone, 2015-03-23 19:35:05]

I think Yaron already gave you the lgtm you needed?

[gone, 2015-03-23 19:39:43]

Aside from some 2014s in the copyright headers, seemed fine to me, too.

https://codereview.chromium.org/1024993003/diff/60001/chrome/browser/android/...
File chrome/browser/android/metrics/variations_session.h (right):

https://codereview.chromium.org/1024993003/diff/60001/chrome/browser/android/...
chrome/browser/android/metrics/variations_session.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
2015

[pkotwicz, 2015-03-23 22:01:14]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-03-23 22:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1024993003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-03-23 22:01:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024993003/80001

[commit-bot: I haz the power, 2015-03-23 23:19:57]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-03-23 23:20:23]

Patchset 4 (id:??) landed as
https://crrev.com/82af6f6b968a2683de21c8dc81cf1fd72bec0322
Cr-Commit-Position: refs/heads/master@{#321891}