Don't update framebuffer_size to 0x0 when the framebuffer size didn't change.

DisplayConfigurator::OnConfigure may get empty framebuffer size when the framebuffer size didn't change. Don't update in that case.

BUG=457395
TEST=covered by unittests

Committed: https://crrev.com/8cf86b6723ceb38b81ea5372b61d23dfadb8bb59
Cr-Commit-Position: refs/heads/master@{#321640}

[oshima, 2015-03-20 18:03:24]

oshima@chromium.org changed reviewers:
+ dnicoara@chromium.org

[oshima, 2015-03-20 18:03:33]

Patchset #2 (id:20001) has been deleted

[oshima, 2015-03-20 18:03:36]

Patchset #1 (id:1) has been deleted

[dnicoara, 2015-03-20 18:36:42]

https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/dis...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/dis...
ui/display/chromeos/display_configurator.cc:929: new_power_state ==
chromeos::DISPLAY_POWER_ALL_OFF);
Shouldn't happen when the display power is all off.
DisplayLayoutManagerImpl::GetDisplayLayout will compute the framebuffer size
based on the selected mode, disregarding the requested power state.

[oshima, 2015-03-20 20:30:08]

https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/dis...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/dis...
ui/display/chromeos/display_configurator.cc:929: new_power_state ==
chromeos::DISPLAY_POWER_ALL_OFF);
On 2015/03/20 18:36:42, dnicoara wrote:
> Shouldn't happen when the display power is all off.
> DisplayLayoutManagerImpl::GetDisplayLayout will compute the framebuffer size
> based on the selected mode, disregarding the requested power state.

when suspending display(s), it may skip actual configuration, which leads to
this state.

[dnicoara, 2015-03-20 20:37:36]

lgtm

https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/dis...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/dis...
ui/display/chromeos/display_configurator.cc:929: new_power_state ==
chromeos::DISPLAY_POWER_ALL_OFF);
On 2015/03/20 20:30:08, oshima wrote:
> On 2015/03/20 18:36:42, dnicoara wrote:
> > Shouldn't happen when the display power is all off.
> > DisplayLayoutManagerImpl::GetDisplayLayout will compute the framebuffer size
> > based on the selected mode, disregarding the requested power state.
> 
> when suspending display(s), it may skip actual configuration, which leads to
> this state. 

Acknowledged.

[oshima, 2015-03-20 20:54:49]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-03-20 20:55:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024943003/40001

[commit-bot: I haz the power, 2015-03-20 21:45:08]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2015-03-20 21:46:12]

Patchset 1 (id:??) landed as
https://crrev.com/8cf86b6723ceb38b81ea5372b61d23dfadb8bb59
Cr-Commit-Position: refs/heads/master@{#321640}