Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1024943003: Don't update framebuffer_size to 0x0 when the framebuffer size didn't change. (Closed)

Created:
5 years, 9 months ago by oshima
Modified:
5 years, 9 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DisplayConfigurator::OnConfigure may get empty framebuffer size when the framebuffer size didn't change. Don't update in that case. BUG=457395 TEST=covered by unittests Committed: https://crrev.com/8cf86b6723ceb38b81ea5372b61d23dfadb8bb59 Cr-Commit-Position: refs/heads/master@{#321640}

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M ui/display/chromeos/display_configurator.cc View 2 chunks +13 lines, -2 lines 3 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 4 chunks +16 lines, -0 lines 0 comments Download
M ui/display/chromeos/update_display_configuration_task.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
oshima
5 years, 9 months ago (2015-03-20 18:03:42 UTC) #4
dnicoara
https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/display_configurator.cc File ui/display/chromeos/display_configurator.cc (right): https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/display_configurator.cc#newcode929 ui/display/chromeos/display_configurator.cc:929: new_power_state == chromeos::DISPLAY_POWER_ALL_OFF); Shouldn't happen when the display power ...
5 years, 9 months ago (2015-03-20 18:36:42 UTC) #5
oshima
https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/display_configurator.cc File ui/display/chromeos/display_configurator.cc (right): https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/display_configurator.cc#newcode929 ui/display/chromeos/display_configurator.cc:929: new_power_state == chromeos::DISPLAY_POWER_ALL_OFF); On 2015/03/20 18:36:42, dnicoara wrote: > ...
5 years, 9 months ago (2015-03-20 20:30:08 UTC) #6
dnicoara
lgtm https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/display_configurator.cc File ui/display/chromeos/display_configurator.cc (right): https://codereview.chromium.org/1024943003/diff/40001/ui/display/chromeos/display_configurator.cc#newcode929 ui/display/chromeos/display_configurator.cc:929: new_power_state == chromeos::DISPLAY_POWER_ALL_OFF); On 2015/03/20 20:30:08, oshima wrote: ...
5 years, 9 months ago (2015-03-20 20:37:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024943003/40001
5 years, 9 months ago (2015-03-20 20:55:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-20 21:45:08 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 21:46:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf86b6723ceb38b81ea5372b61d23dfadb8bb59
Cr-Commit-Position: refs/heads/master@{#321640}

Powered by Google App Engine
This is Rietveld 408576698