Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4682)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 1024943002: Add domain request detection to incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add DomainRequest incident type to histograms.xml Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index cf487918fdfe4e0d7249bcbfc6a9fc84decbeea4..abd6d3258d4e3e0148750933c83e721fcba4d0f7 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -371,6 +371,10 @@ message ClientIncidentReport {
optional string script_digest = 1;
optional string inclusion_origin = 2;
}
+ message DomainRequestIncident {
grt (UTC plus 2) 2015/03/20 20:50:04 This new type is so similar to the existing one, t
grt (UTC plus 2) 2015/03/21 01:30:07 I just remembered that enums in protobufs must sta
romanl 2015/03/26 22:01:47 Done.
romanl 2015/03/26 22:01:47 Done.
+ optional string domain_digest = 1;
+ optional string request_origin = 2;
+ }
optional int64 incident_time_msec = 1;
optional TrackedPreferenceIncident tracked_preference = 2;
optional BinaryIntegrityIncident binary_integrity = 3;
@@ -378,6 +382,7 @@ message ClientIncidentReport {
// Note: skip tag 5 because it was previously used.
optional VariationsSeedSignatureIncident variations_seed_signature = 6;
optional ScriptRequestIncident script_request = 7;
+ optional DomainRequestIncident domain_request = 8;
}
repeated IncidentData incident = 1;

Powered by Google App Engine
This is Rietveld 408576698