Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 1024943002: Add domain request detection to incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove empty line for consistency Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 637993a8f0aaeee09cbe68423ca45a22b2cd8ad5..53e26badeb4a973b0a4ee05b21d924386037ed81 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -57,7 +57,7 @@
#include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer.h"
#include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"
#include "chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.h"
-#include "chrome/browser/safe_browsing/incident_reporting/script_request_detector.h"
+#include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"
#include "chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h"
#endif
@@ -233,7 +233,7 @@ void SafeBrowsingService::Initialize() {
if (IsIncidentReportingServiceEnabled()) {
incident_service_.reset(new safe_browsing::IncidentReportingService(
this, url_request_context_getter_));
- script_request_detector_.reset(new safe_browsing::ScriptRequestDetector(
+ resource_request_detector_.reset(new safe_browsing::ResourceRequestDetector(
incident_service_->GetIncidentReceiver()));
}
@@ -282,7 +282,7 @@ void SafeBrowsingService::ShutDown() {
#if defined(FULL_SAFE_BROWSING)
off_domain_inclusion_detector_.reset();
- script_request_detector_.reset();
+ resource_request_detector_.reset();
incident_service_.reset();
#endif
@@ -364,8 +364,8 @@ void SafeBrowsingService::OnResourceRequest(const net::URLRequest* request) {
#if defined(FULL_SAFE_BROWSING)
if (off_domain_inclusion_detector_)
off_domain_inclusion_detector_->OnResourceRequest(request);
- if (script_request_detector_)
- script_request_detector_->OnResourceRequest(request);
+ if (resource_request_detector_)
+ resource_request_detector_->OnResourceRequest(request);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698